git.net

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Test before PR


On 09/10/18 11:07, Abdur-Rahmaan Janhangeer wrote:
> just a simple question. how do you test PR before merge?

I doubt there's a single answer to that question.

Some things like documentation changes can just be read, code reviews 
might work for sufficiently small changes, and so on.  If you have a 
test suite, of course, run it.

I'm an embedded engineer, and sometimes testing changes fully involve 
creating hardware setups that are not trivial.  It's not always 
practical to run those tests for everything.  You sometimes just have to 
make a judgement about what is reasonable to test, and hope that later 
QA and pre-release testing (which should involve running those 
hard-to-set-up tests) will catch anything that slips through.

-- 
Rhodri James *-* Kynesim Ltd