git.net

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[nova][dev] Which response code should be returned when migrate is called but the src host is offline?


On Tue, 12 Feb 2019 at 18:06, Lee Yarwood <lyarwood at redhat.com> wrote:
>
> Hello all,
>
> I can't seem to settle on an answer for $subject as part this bugfix:
>
> compute: Reject migration requests when source is down
> https://review.openstack.org/#/c/623489/
>
> 409 suggests that the user is able to address the issue while 503
> suggests that n-api itself is at fault. I'd really appreciate peoples
> thoughts on this given I hardly ever touch n-api.

I don't think it means n-api is at fault, I think it means that nova,
as a whole, is temporarily unable to fulfil the request for reasons
which can't be resolved using the API, but might be fixed if you wait
a bit. The weird thing about this specific request is that, being an
admin api, the person you might be waiting on to fix it might be
yourself. It's still OOB, though: compute host down isn't something
you can fix using the API. 409 to me means you raced with something,
or something is in the wrong state, and you need to go do other things
with the API before coming back here and trying again. 503 to me means
we can't do it no matter what you do because, well, 'Service
Unavailable'. Which it is, because the compute host is down.

This isn't a hill I'm prepared to die on, though, just my 2c ;)

Matt
-- 
Matthew Booth
Red Hat OpenStack Engineer, Compute DFG

Phone: +442070094448 (UK)