git.net

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[oslo][kolla][requirements][release][infra] Hit by an old, fixed bug



On 12/30/19 9:52 AM, RadosÅ?aw Piliszek wrote:
> Thanks, Sean! I knew I was missing something really basic!
> I was under the impression that 9.x is Stein, like it happens with
> main projects (major=branch).
> I could not find any doc explaining oslo.messaging versioning, perhaps
> Oslo could release 9.5.1 off the stein branch?

Oslo for the most part follows semver, so we only bump major versions 
when there is a breaking change. We bump minor versions each release so 
we can do bugfix releases on the previous stable branch without stepping 
on master releases.

The underlying cause of this is likely that I'm way behind on releasing 
the Oslo stable branches. It's high on my todo list now that most people 
are back from holidays and will be around to help out if a release 
breaks something.

However, anyone can propose a release[0][1] (contrary to what [0] 
suggests), so if the necessary fix is already on stable/stein and just 
hasn't been released yet please feel free to do that. You'll just need a 
+1 from either myself or hberaud (the Oslo release liaison) before the 
release team will approve it.

0: https://releases.openstack.org/reference/using.html#requesting-a-release
1: 
https://releases.openstack.org/reference/using.html#using-new-release-command

> 
> The issue remains that, even though oslo backports bugfixes into their
> stable branches, kolla (and very possibly other deployment solutions)
> no longer benefit from them.
> 
> -yoctozepto
> 
> pon., 30 gru 2019 o 16:01 Sean McGinnis <sean.mcginnis at gmx.com> napisaÅ?(a):
>>
>> On Sun, Dec 29, 2019 at 09:41:45PM +0100, RadosÅ?aw Piliszek wrote:
>>> Hi Folks,
>>>
>>> as the subject goes, my installation has been hit by an old bug:
>>> https://bugs.launchpad.net/oslo.messaging/+bug/1828841
>>> (bug details not important, linked here for background)
>>>
>>> I am using Stein, deployed with recent Kolla-built source-based images
>>> (with only slight modifications compared to vanilla ones).
>>> Kolla's procedure for building source-based images considers upper
>>> constraints, which, unfortunately, turned out to be lagging behind a
>>> few releases w.r.t. oslo.messaging at least.
>>> The fix was in 9.7.0 released on May 21, u-c still point to 9.5.0 from
>>> Feb 26 and the latest of Stein is 9.8.0 from Jul 18.
>>>
>>> It seems oslo.messaging is missing from the automatic updates that bot proposes:
>>> https://review.opendev.org/#/q/owner:%22OpenStack+Proposal+Bot%22+project:openstack/requirements+branch:stable/stein
>>>
>>> Per:
>>> https://opendev.org/openstack/releases/src/branch/master/doc/source/reference/reviewer_guide.rst#release-jobs
>>> this upper-constraint proposal should be happening for all releases.
>>>
>>
>> This is normal and what is expected.
>>
>> Requirements are only updated for the branch in which those releases happen. So
>> if there is a release of oslo.messaging for stable/train, only the stable/train
>> upper constraints are updated for that new release. The stable/stein branch
>> will not be affected because that shows what the tested upper constraints were
>> for that branch.
>>
>> The last stable/stein release for oslo.messaging was 9.5.0:
>>
>> https://opendev.org/openstack/releases/src/branch/master/deliverables/stein/oslo.messaging.yaml#L49
>>
>> And 9.5.0 is what is set in the stable/stein upper-constraints:
>>
>> https://opendev.org/openstack/requirements/src/branch/stable/stein/upper-constraints.txt#L146
>>
>> To get that raised, whatever necessary bugfixes that are required in
>> oslo.messaging would need to be backported per-cycle until stable/stein (as in,
>> if it was in current master, it would need to be backported and merged to
>> stable/train first, then stable/stein), and once merged a stable release would
>> need to be proposed for that branch's version of the library.
>>
>> Once that stable release is done, that will propose the update to the upper
>> constraint for the given branch.
>>
>>> I would be glad if someone investigated why it happens(/ed) and
>>> audited whether other OpenStack projects don't need updating as well
>>> to avoid running on old deps when new are awaiting for months. :-)
>>> Please note this might apply to other branches as well.
>>>
>>> PS: for some reason oslo.messaging Stein release notes (
>>> https://docs.openstack.org/releasenotes/oslo.messaging/stein.html )
>>> are stuck at 9.5.0 as well, this could be right (I did not inspect the
>>> sources) but I am adding this in PS so you have more things to
>>> correlate if they need be.
>>>
>>
>> Again, as expected. The last stable/stein release was 9.5.0, so that is correct
>> that the release notes for stein only show up to that point.
>