[ironic] Should we add ironic-prometheus-exporter under Ironic umbrella?
This seems pretty awesome. I threw in some comments
On Fri, Jun 7, 2019 at 11:08 AM Iury Gregory <iurygregory at gmail.com> wrote:
> Greetings Ironicers!
> I would like to have your input on the matter of moving the ironic-prometheus-exporter to Ironic umbrella.
> What is the ironic-prometheus-exporter?
> The ironic-prometheus-exporter provides a way to export hardware sensor data from
> Ironic project in OpenStack to Prometheus . It's implemented as an oslo-messaging notification driver to get the sensor data and a Flask Application to export the metrics to Prometheus. It can not only be used in metal3-io but also in any OpenStack deployment which includes Ironic service.
This seems really neat. From my perspective, it seems like it waits
for notifications, and then writes it out to a file. The flask server
seems to do nothing but pretty much serve the contents at /metrics. I
think we should be doing more of this inside OpenStack to be honest
and this can be really useful in the perspective of operators.
I don't want to complicate this more however, but I would love for
this to be a pattern/framework that other projects can adopt.
> How to ensure the sensor data will follow the Prometheus format?
> We are using the prometheus client_python  to generate the file with the metrics that come trough the oslo notifier plugin.
> How it will be tested on the gate?
> Virtualbmc can't provide sensor data that the actual plugin supports. We would collect sample metrics from the hardware and use it in the unit tests.
> Maybe we should discuss this in the next ironic weekly meeting (10th June)?
>  https://github.com/metal3-io/ironic-prometheus-exporter
>  https://prometheus.io/
>  https://github.com/prometheus/client_python
> Iury Gregory Melo Ferreira
> MSc in Computer Science at UFCG
> Part of the puppet-manager-core team in OpenStack
> Software Engineer at Red Hat Czech
> Social: https://www.linkedin.com/in/iurygregory
> E-mail: iurygregory at gmail.com
Mohammed Naser â?? vexxhost
D. 800-910-1726 ext. 200
E. mnaser at vexxhost.com