[watcher] Compute CDM builder issues (mostly perf related)
On 5/15/2019 4:19 AM, li.canwei2 at zte.com.cn wrote:
> IÂ triedÂ changingÂ nova_client.api_versionÂ toÂ aÂ FloatOptÂ butÂ thatÂ gets
> messyÂ becauseÂ ofÂ howÂ thingsÂ likeÂ 2.60Â areÂ handledÂ (str(2.60)Â getsÂ turned
> intoÂ '2.6'Â whichÂ isÂ notÂ whatÂ we'dÂ want).Â IÂ wasÂ hopingÂ weÂ couldÂ use
> FloatOptÂ withÂ aÂ minÂ versionÂ toÂ enforceÂ theÂ minimumÂ requiredÂ version,Â but
> IÂ guessÂ weÂ couldÂ doÂ thisÂ otherÂ waysÂ inÂ theÂ clientÂ helperÂ codeÂ itselfÂ by
> comparingÂ toÂ someÂ minimumÂ requiredÂ versionÂ inÂ theÂ code.
> [licanwei]: Maybe we can refer to
I just did this which seems more explicit:
That change leaves the default of 2.56 since the 2.56 code does version
discovery so it's backward compatible, but I think we can assert that
you need at least 2.53 because of how the scoped nova CDM code works
(and to support nova deployments with multiple cells properly).
Also note that 2.53 is pike-era nova and 2.56 is queens-era nova and
those seem old enough that it's safe to require 2.53 as a minimum for
watcher in train.