Subject: Re: iphlpapi: Avoid sockaddr scope confusion



On Wed, Jan 11, 2017 at 6:51 PM, Alexandre Julliard <[email protected]> wrote:
> Bruno Jesus <[email protected]> writes:
>
>> On Wed, Jan 11, 2017 at 6:14 PM, Alexandre Julliard <[email protected]>
>> wrote:
>>> André Hentschel <[email protected]> writes:
>>>
>>>> Signed-off-by: André Hentschel <[email protected]>
>>>> ---
>>>> dlls/iphlpapi/iphlpapi_main.c | 2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> This doesn't look to me like an improvement.
>>
>> It is an improvement because a same name variable is declared inside a
>> for [2] lines below this one. So reducing the scope will make the
>> variables no longer overlap.
>
> It's a different scope, they already don't overlap. It's done the same
> way as the v4 case above it.

You are right, they are not in the same scope. Yet it is not exactly
like ipv4 case. Line 1116 declares the prefix and line 1122 the sa,
while in the ipv6 case both variables are declared in 1078. The change
makes the code look more similar by declaring the ipv6 sa inside the
for just like the ipv4.




Programming list archiving by: Enterprise Git Hosting