Subject: Re: iphlpapi: Avoid sockaddr scope confusion



On Wed, Jan 11, 2017 at 6:14 PM, Alexandre Julliard <julliard@xxxxxxxxxx> wrote:
> André Hentschel <nerv@xxxxxxxxxxx> writes:
>
>> Signed-off-by: André Hentschel <nerv@xxxxxxxxxxx>
>> ---
>> dlls/iphlpapi/iphlpapi_main.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> This doesn't look to me like an improvement.

It is an improvement because a same name variable is declared inside a
for [2] lines below this one. So reducing the scope will make the
variables no longer overlap.

[1] http://source.winehq.org/source/dlls/iphlpapi/iphlpapi_main.c#1079
[2] http://source.winehq.org/source/dlls/iphlpapi/iphlpapi_main.c#1122




Programming list archiving by: Enterprise Git Hosting