Subject: [Differential] [Updated, 179 lines] D3965: OSM
notes: improved rendering



spencerb updated the summary for this revision. (Show Details)
spencerb updated the test plan for this revision. (Show Details)
spencerb updated this revision to Diff 10008. View Revision
EDIT DETAILSGCI task: https://codein.withgoogle.com/dashboard/task-instances/5145983602130944/

This is what i have so far. I think these are all of the relevant json properties.
Where is the best place to display these? Should I create a popup layer or just show them in a tooltip? Finally, if we want to have a popup or anything like that, do we want to show each comment for a note? Otherwise we definitely wouldn't have enough space to display multiple comments - possibly enough for just the initial note though.
EDIT DETAILSLooks to me like everything works. I tweaking the elipsed text to have be a little longer/wider since anyone who doesn't want to see it can always disable the notes plugin and with the previous length every note was elipsed, with just 3-4 chars readable.
REPOSITORYR34 Marble
CHANGES SINCE LAST UPDATEhttps://phabricator.kde.org/D3965?vs=10006&id=10008
REVISION DETAILhttps://phabricator.kde.org/D3965
AFFECTED FILESdata/bitmaps/notes_closed.png
dat...

a/bitmaps/notes_open.png
src/plugins/render/notes/NotesItem.cpp
src/plugins/render/notes/NotesItem.h
src/plugins/render/notes/NotesModel.cpp
src/plugins/render/notes/NotesPlugin.cpp
EMAIL PREFERENCEShttps://phabricator.kde.org/settings/panel/emailpreferences/
To: spencerb, rahn, nienhueser, Marble
Cc: mnafees, shentey, chaz6, dkolozsvari, cmihalache, rahn, nienhueser, marble-devel



Programming list archiving by: Enterprise Git Hosting