Subject: Re: Review Request 129807: proposal: add ksvg2ico



This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129807/

On January 11th, 2017, 9:54 p.m. CET, Christoph Feck wrote:

Could you test it with an SVG file that contains text? From what I remember, painting text requires a QGuiApplication to access the font database.

Additionally, I do not like the hand-made command line parsing. We have QCommandLineParser for this.

I said "partly rewritten", right? :)

You're probably right about using QGuiApplication, I notice that ksvg2icns uses that too, so I'll align.


On January 11th, 2017, 9:54 p.m. CET, Christoph Feck wrote:

src/CMakeLists.txt (Diff revision 1)

5
add_subdirectory(tools/ksvg2ico)
Is it actually useful on non-Windows systems? If not, please add a conditional similar to the Apple tool above.

I could imagine it being used in various forms of cross-platform development. Ksvg2icns is built only on Mac because it relies on a platform utility that doesn't exist elsewhere, but png2ico is cross-platform itself. I can put in a conditional, but as a last step if I want to keep testing until the end ;)


- René J.V.


On January 12th, 2017, 10:47 a.m. CET, René J.V. Bertin wrote:

Review request for KDE Frameworks, kdewin, Alex Merry, and Christoph Feck. By René J.V. Bertin.

Updated Jan. 12, 2017, 10:47 a.m.

Repository: kiconthemes Description

Recently I committed a few changes to ecm_add_app_icon that make use of the fact that KIconThemes includes a ksvg2icns utility, making it possible to generate an application icon from an SVG file instead of from a series of PNG files.

With the present patch I propose to add an updated and partly rewritten version of the ageing svg2ico tool from the KDEWin project to KIconThemes. The goal is to have a proper and up-to-date tool to generate application icons from SVG on MS Windows too.

I considered proposing it to KDEWin instead, but in the end I liked the idea better to provide icon conversion utilities for Mac and Windows with a framework, where they might also serve in a less KDE-centric context (and cross-platform development). I also played with the idea of integrating the png2ico step into the tool, but noticed during testing that Matthias Benkmann's png2ico supports input sizes up to 248x248 while KDEWin's png2ico is currently limited at 48x48 or maybe even 32x32. Lacking a MSWin development system I'm not volunteering to update that code.

Testing

On Mac OS X 10.9 with Qt 5.7.1 and KF5 5.29.0 .

Diffs
  • src/CMakeLists.txt (efba9e6)
  • src/tools/ksvg2ico/CMakeLists.txt (PRE-CREATION)
  • src/tools/ksvg2ico/ksvg2ico.cpp (PRE-CREATION)

View Diff

File Attachments
  • .ico file generated from sc-apps-calligrakarbon.svgz using ksvg2ico with Benkmann's png2ico
  • .ico created by icotool from *-apps-calligrakarbon.png


  • Programming list archiving by: Enterprise Git Hosting