Subject: Re: Review Request 130217: kbruch- Change
QCheckBoxes under "Answer" section to
QRadioButtons to avoid multiple checks.



This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130217/

On August 4th, 2017, 11:14 p.m. UTC, Aleix Pol Gonzalez wrote:

Screenshot for before and after?

Thank you very much. I will take care of it from next request onwards!


- Aman


On August 5th, 2017, 6:18 a.m. UTC, Aman Kumar Gupta wrote:

Review request for KDE Edu. By Aman Kumar Gupta.

Updated Aug. 5, 2017, 6:18 a.m.

Bugs: 357675 Repository: kbruch Description

Patch for Bug ID-357657. Replaced QCheckbox objects named "m_AnswerMixedCheck" and "m_ReducedCheck" to QRadioButton to select only one option in displaying the type of Answer(either Mixed Fraction or Reduced form).

Testing




white-space: -o-pre-wrap; word-wrap: break-word;">

It works successfully without any bugs fulfilling the objective of the patch. QCheckBoxes under "Answer Section" replaced with QRadioButtons, changes reflected to both, MainQtWidget.h as well as MainQtWidget.cpp.

Diffs
  • src/MainQtWidget.h (dc62307)
  • src/MainQtWidget.cpp (c522145)

View Diff

File Attachments
  • Before patch. Both options under "Answer" checked.
  • Before patch. Both options under "Answer" unchecked.
  • After patch. Changed QCheckBoxes to QRadiobuttons
  • Only one option out of Mixed and Reduced can be selected.


  • Programming list archiving by: Enterprise Git Hosting