Subject: [Bug 1468873] Review Request:
python-click-plugins - Click extension to enable
registering CLI commands via setuptools

Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed:

What |Removed |Added
Status|NEW |POST
CC| |zbyszek@xxxxxxxxx
Blocks|177841 (FE-NEEDSPONSOR) |
Assignee|nobody@xxxxxxxxxxxxxxxxx |zbyszek@xxxxxxxxx
Flags| |fedora-review+

--- Comment #2 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> ---
I like the following trick:
%global _description \
An extension module for click to register external CLI commands via setuptools\

%description %_description
%description -n python2-%{srcname} %_description
%description -n python3-%{srcname} %_description

... but of course repeating the description text is OK.

Minor nitpick: the description line is very long, dnf list will look ugly.
What about: "Click extension to register CLI commands via setuptools"?

This is nice and straightforward:
+ package name is OK
+ license is acceptable for Fedora (MIT)
+ license is specified correctly
+ follows the modern python packaging template
+ builds and installs OK
+ no scriptlets needed
+ %check is present and passes
+ %license macro is used
+ %python_provide is used

Only false positive ramblings about toadstools.

Package is APPROVED.

Referenced Bugs:
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
You a...

re receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx

Programming list archiving by: Enterprise Git Hosting