Subject: [Bug 1479967] Review Request: fritzing-parts -
Parts library for the Fritzing electronic design
application



https://bugzilla.redhat.com/show_bug.cgi?id=1479967

Robert-André Mauchin <zebob.m@xxxxxxxxx> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |zebob.m@xxxxxxxxx



--- Comment #1 from Robert-André Mauchin <zebob.m@xxxxxxxxx> ---
Hello,


No time to do a full review right now, but here's a preliminary couple of
issues:

- The tag "Group:" is to be removed. See
https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections

- Your patches… what do they do? Have they been reported upstream? Do you have
a bug number for them? See
https://fedoraproject.org/wiki/Packaging:Guidelines#All_patches_should_have_an_upstream_bug_link_or_comment

- Change:

Source0:
https://github.com/fritzing/%{name}/archive/%{version}.tar.gz#/%{name}-%{version}.tar.gz


to

Source0:
https://github.com/fritzing/%{name}/archive/%{version}/%{name}-%{version}.tar.gz

- %defattr(-,root,root,-) is not needed. See
https://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions

--
You are receiving this mail because:
You are on the CC list for the b...

ug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx



Programming list archiving by: Enterprise Git Hosting