Subject: Re: [E-devel] [EGIT] [core/efl] master 01/01:
build: enable -Wfloat-equal for compiling



On Wed, 21 Dec 2016 19:38:33 -0200 Gustavo Sverzut Barbieri
<[email protected]> said:

> >> Floating point comparison in C leads to very difficult to diagnose bugs.
> >>
> >> I'm strongly in favor of turning this warning back on immediately.
> >
> > Then only where it makes sense please. Even then, I don't think
> > forcing the whole community to deal with this is the right approach.
> > I'm with Stefan here, first work in a branch, and then when the
> > number of warnings is actually reasonable, push to master.
>
> we do that for other things, like he said... unused parameters. which
> is actually a strange thing, because we get a warning if we don't use
> the parameter but didn't flag them as such (EINA_UNUSED), but if we
> later change the code to use it, there's no warning "using argument
> marked as unused"... I know in my whole efl_net code I may have left
> many of those due lack of warning... since more often than not I
> didn't use "Eo *o", just "... *pd", and then I added some check/method
> that uses "o" and I forgot to unmark it.
>
> Then either change the policy of the whole project, or let's stick to
> it as zmike/derek pointed.

there is a difference tho. making a param as unised has no effect on code
generated or behaviour. at least last time i read the attribute docs for unused
- they are just a hint to the compiler to not warn about that unused param

the changes being made in efl now actually change the code behaviour to no
longer be able to do an exact comparison e.g with 0.0 or 1.0. if we had a
"harmless" solution to just disable the warning for that comparison i think
we'd have a good ...

solution and if it was used appropriately for the comparisons
i think we'd all be happy.

> --
> Gustavo Sverzut Barbieri
> --------------------------------------
> Mobile: +55 (16) 99354-9890
>
> ------------------------------------------------------------------------------
> Developer Access Program for Intel Xeon Phi Processors
> Access to Intel Xeon Phi processor-based developer platforms.
> With one year of Intel Parallel Studio XE.
> Training and support from Colfax.
> Order your platform today.http://sdm.link/intel
> _______________________________________________
> enlightenment-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>


--
------------- Codito, ergo sum - "I code, therefore I am" --------------
The Rasterman (Carsten Haitzler) [email protected]


[email protected]-------------
Developer Access Program for Intel Xeon Phi Processors
Access to Intel Xeon Phi processor-based developer platforms.
With one year of Intel Parallel Studio XE.
Training and support from Colfax.
Order your platform today.http://...

sdm.link/intel

_______________________________________________
enlightenment-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel



Programming list archiving by: Enterprise Git Hosting