git.net

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] mod_deflate: hardcoded "%ld" -> APR_OFF_T_FMT


On Sun, Dec 16, 2018 at 1:28 PM Stefan Sperling <stsp@xxxxxxxxxx> wrote:
>
> mod_deflates hard-codes some off_t format directives to "%ld".
> It seems to me this code should use the macro provided by APR instead.
>
> Looking for another pair of eyes. Does this patch look good to commit?

It seems that zlib defines total_in/out as uLong, i.e.:
typedef struct z_stream_s {
    [...]
    uLong    total_in;  /* total number of input bytes read so far */
    [...]
    uLong    total_out; /* total number of bytes output so far */
    [...]
} z_stream;

So %ld (or %lu) looks correct to me.

(mod_brotli uses apr_off_t for them but it's an internal struct there).

Regards,
Yann.