git.net

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: svn commit: r1840265 - in /httpd/httpd/trunk: include/ap_mmn.h include/util_filter.h modules/http/http_request.c server/core_filters.c server/util_filter.c


On Fri, Sep 7, 2018 at 4:52 AM Yann Ylavic <ylavic.dev@xxxxxxxxx> wrote:

There probably are other "includes/" candidates, like:
  ap_expr_init (ap_expr.h)
  ap_open_logs (http_log.h)
  ap_logs_child_init (http_log.h)
  ap_add_output_filters_by_type (http_core.h)
  ap_core_reorder_directories (http_core.h)
  ap_process_async_request (http_request.h)
  ap_create_scoreboard (scoreboard.h)
  ap_http_filter (mod_core.h)
  ap_http_chunk_filter (mod_core.h)
  ap_http_outerror_filter (mod_core.h)
  ap_response_code_string (mod_core.h)
  util_ldap_cache_init (util_ldap.h)
  util_ald_cache_display (util_ldap.h)
  ...

Shouldn't we do something fot them too?

Keep in mind third party MPM's... but yes many of these are good candidates
for internals, +1 after review.