git.net

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Bug in mod_ratelimit?


Hi Luca,

On Thu, Jul 19, 2018 at 9:59 PM, Luca Toscano <toscano.luca@xxxxxxxxx> wrote:
>
> I confirm that it works fine in my local dev environment, plus now gdb's
> dump_brigade makes sense, but I am not sure that I have understood what was
> wrong. In my tests, the headers were the first heap bucket reported by
> dump_brigade in gdb (before your patch), so IIUC we were saving them to
> holdingbb and then finally passing them via ap_pass_brigade. But I thought
> that this was they way to go, what am I missing? I am pretty sure this is
> basic filter knowledge but I have missed it up to now, if not present in the
> docs already I'll make sure to add it.

You probably didn't test with chunked encoding (neither did I!), see
how ap_http_header_filter() adds the "CHUNK" filter after the headers
have been sent, so if anything retains the headers they will be
considered as the body by the (late) ap_http_chunk_filter()...

Regards,
Yann.