git.net

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: svn commit: r1836237 - in /httpd/httpd/trunk: modules/ssl/ssl_engine_io.c server/core_filters.c server/util_filter.c


On Thu, Jul 19, 2018 at 4:29 AM, Eric Covener <covener@xxxxxxxxx> wrote:
>> +static APR_INLINE int is_in_memory_bucket(apr_bucket *b)
>> +{
>> +    /* The bucket data are already in memory unless:
>> +     *   - it's a morphing bucket (heap buffers allocated on read), or
>> +     *   - it's a file bucket (heap buffers also allocated on read), or
>> +     *   - it's a mmap bucket (mapping happens over memory access usually).
>> +     */
>> +    return b->length != (apr_size_t)-1
>> +           && !APR_BUCKET_IS_FILE(b)
>> +           && !APR_BUCKET_IS_MMAP(b);
>> +}
>
> Is this blacklist style safe? Could out-of-tree bucket types act close
> to file/mmap buckets?

Good point, switched to a whitelist in r1836258.
Ideally we'd provide a hook for third-parties to possibly add their
memory buckets, no need/request for now obviously...



( ! ) Warning: include(msgfooter.php): failed to open stream: No such file or directory in /var/www/git/apache2-developers/msg04309.html on line 88
Call Stack
#TimeMemoryFunctionLocation
10.0007358376{main}( ).../msg04309.html:0

( ! ) Warning: include(): Failed opening 'msgfooter.php' for inclusion (include_path='.:/var/www/git') in /var/www/git/apache2-developers/msg04309.html on line 88
Call Stack
#TimeMemoryFunctionLocation
10.0007358376{main}( ).../msg04309.html:0