git.net

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug 60296] RMM list corruption in ldap module results in server hang


On Fri, Jun 15, 2018 at 10:55 AM Yann Ylavic <ylavic.dev@xxxxxxxxx> wrote:
>
> On Fri, Jun 15, 2018 at 4:25 PM, Eric Covener <covener@xxxxxxxxx> wrote:
> > Should we swap fnctl and flock?
>
> Is flock() any better on all systems?

I am not sure, but it at least does not document EDEADLCK on Linux
like fcntl does.

>
> >
> > Or block file: for 'default' since it would choose multiple fcntls?
>
> Looks sensible, or choose the one or the other depending on which
> works better for a particular system (if we can determine this..).

Good point. The manual currently lists Solaris as problematic but i
think it's too narrow.  Of course mod_ldap was complicit in all of
this with not checking return values or even logging errors.

-- 
Eric Covener
covener@xxxxxxxxx