git.net

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: svn commit: r1818725 - /httpd/httpd/trunk/modules/md/md_acme_drive.c


On Tue, Dec 19, 2017 at 11:39 PM,  <ylavic@xxxxxxxxxx> wrote:
>
> --- httpd/httpd/trunk/modules/md/md_acme_drive.c (original)
> +++ httpd/httpd/trunk/modules/md/md_acme_drive.c Tue Dec 19 22:39:03 2017
> @@ -566,18 +566,11 @@ static apr_status_t get_chain(void *bato
>  {
>      md_proto_driver_t *d = baton;
>      md_acme_driver_t *ad = d->baton;
> -    md_cert_t *cert;
>      const char *prev_link = NULL;
>      apr_status_t rv = APR_SUCCESS;
>
>      while (APR_SUCCESS == rv && ad->chain->nelts < 10) {
>          int nelts = ad->chain->nelts;
> -        if (ad->chain && nelts > 0) {
> -            cert = APR_ARRAY_IDX(ad->chain, nelts - 1, md_cert_t *);
> -        }
> -        else {
> -            cert = ad->cert;
> -        }

Stefan, was 'cert' intended for a particular (future) use or is it a
remainder of some deleted code?
In the latter case, I'd merge this commit in ^/branches/2.4.x-mod_md,
otherwise I'll let you take care of it :)


Regards,
Yann.



( ! ) Warning: include(msgfooter.php): failed to open stream: No such file or directory in /var/www/git/apache2-developers/msg03991.html on line 98
Call Stack
#TimeMemoryFunctionLocation
10.0005363576{main}( ).../msg03991.html:0

( ! ) Warning: include(): Failed opening 'msgfooter.php' for inclusion (include_path='.:/var/www/git') in /var/www/git/apache2-developers/msg03991.html on line 98
Call Stack
#TimeMemoryFunctionLocation
10.0005363576{main}( ).../msg03991.html:0