git.net

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: A proposal...


On Mon, Apr 23, 2018 at 1:05 PM, Jim Jagielski <jim@xxxxxxxxxxx> wrote:
>
>> On Apr 23, 2018, at 12:54 PM, William A Rowe Jr <wrowe@xxxxxxxxxxxxx> wrote:
>>
>> +1; I see any "patch" releases (semver definition) as adopting well-tested bug
>> fixes. In some cases, complex patches could arrive first on a new minor branch
>> for longer alpha/beta scrutiny, before being accepted as-a-patch. This
>> could have
>> helped our php-fpm users with that crazy 2.4.2# cycle of tweak-and-break.
>
> What really helped was having test cases, which are now part
> of the test framework.

More to the point this would have always been iterative. Fix one to break
another. You aren't going to anticipate every side effect writing the
initial test.

It would be great to understand how our PR system failed us in engaging
with PHP users to identify *all* the side effects of 'whatever' change we were
making to the location transcription. And tests were added as things were
broken, more tests added and those broke other things.

To suggest tests would have solved this is silly. The tests were necessary,
and derived from user reports of testing out our code. That it took so many
releases over a year was sort of inexplicable, and if we can sort that out,
we will end up with a better process no matter how we change test rules
or release versioning.



( ! ) Warning: include(msgfooter.php): failed to open stream: No such file or directory in /var/www/git/apache2-developers/msg03894.html on line 96
Call Stack
#TimeMemoryFunctionLocation
10.0006363400{main}( ).../msg03894.html:0

( ! ) Warning: include(): Failed opening 'msgfooter.php' for inclusion (include_path='.:/var/www/git') in /var/www/git/apache2-developers/msg03894.html on line 96
Call Stack
#TimeMemoryFunctionLocation
10.0006363400{main}( ).../msg03894.html:0