git.net

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: svn commit: r1829642 - in /httpd/httpd/trunk: CHANGES modules/http/http_filters.c


I don't remember this at all but:

http://svn.apache.org/viewvc?rev=1031564&view=rev



On Fri, Apr 20, 2018 at 7:06 AM, Eric Covener <covener@xxxxxxxxx> wrote:
> On Fri, Apr 20, 2018 at 6:54 AM, Yann Ylavic <ylavic.dev@xxxxxxxxx> wrote:
>> On Fri, Apr 20, 2018 at 11:50 AM, Eric Covener <covener@xxxxxxxxx> wrote:
>>>
>>> Not sure about change but re: comment
>>>
>>> Are those comparable? The new proxy parm ResponseFieldSize is like
>>> LimitRequestFieldSize not LimitRequestBody?
>>
>> Yes indeed, I made a confusion here (comment restored in r1829643).
>>
>> Regarding the code change itself (!proxyreq => proxyreq !=
>> PROXYREQ_RESPONSE), I think this is the right thing to do because
>> otherwise we don't limit proxyied *request* bodies. Actually I had
>> this patch locally for a while, just noticing it now by adding the
>> ap_rgetline() stuff (that I need to "release" ASAP :) . Will re-check
>> if this is the case.
>>
>> This change is possibly not backportable to 2.4 though.
>
> It rings a bell, I  only meant I had not really thought about the
> change not that it was suspicious, sorry for the wording.
> I think i actually initiated a thread about this confusing choice many
> years ago, I will see if I can dig it up.
>
>
> --
> Eric Covener
> covener@xxxxxxxxx



-- 
Eric Covener
covener@xxxxxxxxx