git.net

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: svn commit: r1829642 - in /httpd/httpd/trunk: CHANGES modules/http/http_filters.c


On Fri, Apr 20, 2018 at 11:50 AM, Eric Covener <covener@xxxxxxxxx> wrote:
>
> Not sure about change but re: comment
>
> Are those comparable? The new proxy parm ResponseFieldSize is like
> LimitRequestFieldSize not LimitRequestBody?

Yes indeed, I made a confusion here (comment restored in r1829643).

Regarding the code change itself (!proxyreq => proxyreq !=
PROXYREQ_RESPONSE), I think this is the right thing to do because
otherwise we don't limit proxyied *request* bodies. Actually I had
this patch locally for a while, just noticing it now by adding the
ap_rgetline() stuff (that I need to "release" ASAP :) . Will re-check
if this is the case.

This change is possibly not backportable to 2.4 though.



( ! ) Warning: include(msgfooter.php): failed to open stream: No such file or directory in /var/www/git/apache2-developers/msg03836.html on line 86
Call Stack
#TimeMemoryFunctionLocation
10.0006363096{main}( ).../msg03836.html:0

( ! ) Warning: include(): Failed opening 'msgfooter.php' for inclusion (include_path='.:/var/www/git') in /var/www/git/apache2-developers/msg03836.html on line 86
Call Stack
#TimeMemoryFunctionLocation
10.0006363096{main}( ).../msg03836.html:0