git.net

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: svn commit: r1829642 - in /httpd/httpd/trunk: CHANGES modules/http/http_filters.c


On Fri, Apr 20, 2018 at 5:46 AM,  <ylavic@xxxxxxxxxx> wrote:
> Author: ylavic
> Date: Fri Apr 20 09:46:51 2018
> New Revision: 1829642
>
> URL: http://svn.apache.org/viewvc?rev=1829642&view=rev
> Log:
> http: LimitRequestBody applies to proxied requests.
>
> If f->r->proxyreq is PROXYREQ_PROXY or PROXYREQ_REVERSE in ap_http_filter(),
> we are still handling the request, not the response where LimitRequestBody
> does not apply.
>
>
> Modified:
>     httpd/httpd/trunk/CHANGES
>     httpd/httpd/trunk/modules/http/http_filters.c
>
> Modified: httpd/httpd/trunk/CHANGES
> URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/CHANGES?rev=1829642&r1=1829641&r2=1829642&view=diff
> ==============================================================================
> --- httpd/httpd/trunk/CHANGES [utf-8] (original)
> +++ httpd/httpd/trunk/CHANGES [utf-8] Fri Apr 20 09:46:51 2018
> @@ -1,6 +1,8 @@
>                                                           -*- coding: utf-8 -*-
>  Changes with Apache 2.5.1
>
> +  *) http: LimitRequestBody applies to proxied requests.  [Yann Ylavic]
> +
>    *) mod_proxy_http: Fix response header thrown away after the previous one
>       was considered too large and truncated. PR 62196. [Yann Ylavic]
>
>
> Modified: httpd/httpd/trunk/modules/http/http_filters.c
> URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/http/http_filters.c?rev=1829642&r1=1829641&r2=1829642&view=diff
> ==============================================================================
> --- httpd/httpd/trunk/modules/http/http_filters.c (original)
> +++ httpd/httpd/trunk/modules/http/http_filters.c Fri Apr 20 09:46:51 2018
> @@ -317,12 +317,11 @@ apr_status_t ap_http_filter(ap_filter_t
>          f->ctx = ctx = apr_pcalloc(f->r->pool, sizeof(*ctx));
>          ctx->state = BODY_NONE;
>
> -        /* LimitRequestBody does not apply to proxied responses.
> +        /* LimitRequestBody does not apply to proxied responses, which have
> +         * their own ResponseFieldSize parameter.


Not sure about change but re: comment

Are those comparable? The new proxy parm ResponseFieldSize is like
LimitRequestFieldSize not LimitRequestBody?