git.net

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Simplifying Fineract CN Demo-server


Happy boxing day fineracters,

Hope you all had a marvelous Christmas day.

I effected some changes based on the open concerns I earlier expressed here
and have just submitted and merged pull requests in
fineract-cn-service-starter and fineract-cn-demo-server repositories in
this respect. For now, I left out any change to the Notifications service's
notificationAdmin role in fineract-cn-demo-server.

My observations indicated a 30% drop in demo-server's build time ( about 7
minutes saved ) on each run - whether Option A or Option B.

I hope this helps.

At Your Service,
Isaac Kamga.

On Sat, Dec 15, 2018 at 12:41 AM Isaac Kamga <isaac.kamga@xxxxxxxxx> wrote:

> Hello fineracters,
>
> Trust that this email finds you well.
>
> Special congratulations to our Google Summer of Code 2018 interns who
> are graduating from University !
>
> In an effort to simplify fineract-cn-demo-server and increase the
> number of eyeballs looking at the platform's code, I've looked into
> demo-server's ServiceRunner and service-starter and have the some
> questions which beg for clarification.
>
> 1. Is it compulsory that the wait time [1] between starting the
> microservices be 20 seconds ? Should this be reduced ? To what extent
> ?
>
> 2. After migrating each service [2] when persistence is true, should
> there be a 5 seconds sleep ?
>
> 3. In the tearDown() method [3], should services be killed in any
> order or in the reverse order in which they were started in the
> before() method [4] ?
>
> 4. +Ebenezer Graham Any special reason why new notificationsAdmin [5]
> role was created ? What if it's possible to use the existing Org Admin
> [6] role and user to allow for permissions related to the
> notifications service just like the other services do ?
>
> 5. Should there be a 40 seconds sleep [7] in Microservice's start()
> method ? Should this be reduced ?
>
> 6. +Markus Geiss Can we default CONCURRENCY from 3-10 to 1-1 in
> ActiveMQForTest [8] ? I remember your advice to Graham regarding
> reduction in the number of received events from 3 to 1.
>
> 7. +Myrle Krantz , How do we run demo-server jar file with debug
> option to start micro-services based on this [9] ? -Dsuspend=y
> -Daddress=3020 ? This could help update the How-To-Build wiki page .
>
> I understand that sometime it's better to apologize than ask for
> permission but given that we want demo-server working for everybody, I
> thought it would be necessary to ask even the most minute details
> concerning changes that affect these integration tests.
>
> Kindly advise on these issues.
>
> At Your Service,
> Isaac Kamga.
>
> [1]
> https://github.com/apache/fineract-cn-demo-server/blob/8a55eb21ef5588796d9212266901b494cdf006f3/src/main/java/org/apache/fineract/cn/dev/ServiceRunner.java#L338
>
> [2]
> https://github.com/apache/fineract-cn-demo-server/blob/8a55eb21ef5588796d9212266901b494cdf006f3/src/main/java/org/apache/fineract/cn/dev/ServiceRunner.java#L355
>
> [3]
> https://github.com/apache/fineract-cn-demo-server/blob/8a55eb21ef5588796d9212266901b494cdf006f3/src/main/java/org/apache/fineract/cn/dev/ServiceRunner.java#L266
>
> [4]
> https://github.com/apache/fineract-cn-demo-server/blob/8a55eb21ef5588796d9212266901b494cdf006f3/src/main/java/org/apache/fineract/cn/dev/ServiceRunner.java#L187
>
> [5]
> https://github.com/apache/fineract-cn-demo-server/blob/8a55eb21ef5588796d9212266901b494cdf006f3/src/main/java/org/apache/fineract/cn/dev/ServiceRunner.java#L653
>
> [6]
> https://github.com/apache/fineract-cn-demo-server/blob/8a55eb21ef5588796d9212266901b494cdf006f3/src/main/java/org/apache/fineract/cn/dev/ServiceRunner.java#L580
>
> [7]
> https://github.com/apache/fineract-cn-service-starter/blob/020dad06bf9f416d819911401e9b370cd155d936/src/main/java/org/apache/fineract/cn/test/servicestarter/Microservice.java#L178
>
> [8]
> https://github.com/apache/fineract-cn-service-starter/blob/020dad06bf9f416d819911401e9b370cd155d936/src/main/java/org/apache/fineract/cn/test/servicestarter/ActiveMQForTest.java#L81
>
> [9]
> https://github.com/apache/fineract-cn-service-starter/blob/020dad06bf9f416d819911401e9b370cd155d936/src/main/java/org/apache/fineract/cn/test/servicestarter/Microservice.java#L171
>