git.net

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Status of Pull Request 405 for Enhancing Notifications Framework


Hi Ed,

The PR was merged by Avik from this PR:
https://github.com/apache/fineract/pull/424

Avik please can you confirm that?

Thanks,
Courage

On Thu, Dec 20, 2018 at 8:52 AM Ed Cable <edcable@xxxxxxxxx> wrote:

> Courage,
>
> It looks like that pull request wasn't actually merged.
>
> Avik, it was closed by asfgit on Dec 13, 2017 with comments from your end.
> Can you shine light on what changes Courage needs to make for PR to be
> merged?
>
> Thanks,
>
> Ed
>
> On Tue, Dec 18, 2018 at 7:09 AM Courage Angeh <courageangeh@xxxxxxxxx>
> wrote:
>
> > Hi Ed,
> >
> > Sorry for the late reply. Here is the link to the documentation used to
> > configure notifications for an event on Fineract.
> >
> >
> https://mifosforge.jira.com/wiki/spaces/docs/pages/153387033/Configure+Notifications
> >
> > Thanks,
> > Courage.
> >
> > On Tue, Dec 11, 2018 at 1:46 PM Ed Cable <edcable@xxxxxxxxx> wrote:
> >
> > > Thanks for the update. So we can close out the ticket on JIRA? Can you
> > > point us to the notifications framework documentation again? For some
> of
> > > the ongoing work with mobile apps in the community, understanding the
> > > points of integration is necessary.
> > >
> > > Ed
> > >
> > > On Tue, Dec 11, 2018 at 9:53 AM Courage Angeh <courageangeh@xxxxxxxxx>
> > > wrote:
> > >
> > > > Hi Ed,
> > > >
> > > > Hope this email finds you well.
> > > > My code was merged. Here is a link to one of the new files I created
> > > during
> > > > GSCOC'17:
> > > >
> > > >
> > >
> >
> https://github.com/apache/fineract/blob/develop/fineract-provider/src/main/java/org/apache/fineract/notification/data/TopicData.java
> > > >
> > > > I will set-up my system to test the notification functionality again.
> > > >
> > > > Thanks,
> > > > Courage.
> > > >
> > > > On Tue, Dec 11, 2018 at 8:25 AM Ed Cable <edcable@xxxxxxxxx> wrote:
> > > >
> > > > > Courage,
> > > > >
> > > > > I thought that all your notifications work had been merged in but
> it
> > > > > appears it hasn't. Can you update the community on outstanding
> issues
> > > to
> > > > > address and what review you need from maintainers to complete this?
> > > > >
> > > > > https://github.com/apache/fineract/pull/405
> > > > >
> > > > > and
> > > > >
> > > > > https://issues.apache.org/jira/browse/FINERACT-527
> > > > >
> > > > > Thanks,
> > > > >
> > > > > Ed
> > > > >
> > > > > --
> > > > > *Ed Cable*
> > > > > President/CEO, Mifos Initiative
> > > > > edcable@xxxxxxxxx | Skype: edcable | Mobile: +1.484.477.8649
> > > > >
> > > > > *Collectively Creating a World of 3 Billion Maries | *
> > http://mifos.org
> > > > > <http://facebook.com/mifos>  <http://www.twitter.com/mifos>
> > > > >
> > > >
> > >
> > >
> > > --
> > > *Ed Cable*
> > > President/CEO, Mifos Initiative
> > > edcable@xxxxxxxxx | Skype: edcable | Mobile: +1.484.477.8649
> > >
> > > *Collectively Creating a World of 3 Billion Maries | *http://mifos.org
> > > <http://facebook.com/mifos>  <http://www.twitter.com/mifos>
> > >
> >
>
>
> --
> *Ed Cable*
> President/CEO, Mifos Initiative
> edcable@xxxxxxxxx | Skype: edcable | Mobile: +1.484.477.8649
>
> *Collectively Creating a World of 3 Billion Maries | *http://mifos.org
> <http://facebook.com/mifos>  <http://www.twitter.com/mifos>
>