git.net

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Error when running Test on Fims


Hi Kelvin,

I think upgrading to Angular 6 is a very good idea and I currently don't
see any other solution.

Before we open a new branch, can you let us know what work you have already
done and what is left over? Are you currently facing any blocking
issues(e.g. components using deprecated angular apis which need a
reimplementation or libs which do not support angular 6)?

I think that information would help if we want to provide some work
packages which can be done seperately if somebody would like to contribute.

On Tue, Nov 20, 2018 at 8:50 PM Kelvin Ikome <kvnikome@xxxxxxxxx> wrote:

> Hi Mark,
>
> I have recently been playing around with the components of Fims Web App and
> in the process, I've been working on an upgrade to Angular 6 which I think
> will solve this issue. What are your thoughts on this approach?
>
> Here is the link to the repository I'm using for the upgrade:
> https://github.com/kelvinikome/fineract-cn-fims-web-app/tree/upgrade
>
> I'm going to need a branch on the Fineract CN repository to send a pull
> request so that others can take a look and contribute to it.
>
> On Tue, Nov 20, 2018 at 7:19 PM Mark van Veen <mark.vanveen@xxxxxxxxx>
> wrote:
>
> > Hi Ruphine,
> >
> > it looks like this issue is related with
> > https://github.com/angular/material2/issues/8213. I could not find a
> quick
> > fix for this.
> >
> > Unfortunately to update to Material 5.0 we have to upgrade Angular,
> > Covalent etc. as well.
> >
> > Mark
> >
> > On Thu, Nov 8, 2018 at 10:12 PM Ruphine Kengne <ruphinekengne@xxxxxxxxx>
> > wrote:
> >
> > > Hello everyone,
> > >
> > > Here is the link to the issue on Jira which I created explaining the
> > > problem I am facing with the PR
> > > https://issues.apache.org/jira/browse/FINCN-102
> > >
> > > Please can someone look at it and help me out?
> > >
> > > Regards,
> > > Ruphine
> > >
> > >
> > > On Tue, 6 Nov 2018 at 23:17, Ruphine Kengne <ruphinekengne@xxxxxxxxx>
> > > wrote:
> > >
> > > > Hi Yannick,
> > > >
> > > > I have not been able to fix the problem with the PR.
> > > >
> > > > I have pulled Mark's latest commit, ran the test but it did not solve
> > the
> > > > problem.
> > > > I will create an issue on Jira explaining the problem so as to get
> > inputs
> > > > from other members of the community.
> > > >
> > > > Regards,
> > > > Ruphine Kengne
> > > >
> > > > On Sat, 3 Nov 2018 at 23:24, Awasum Yannick <awasum@xxxxxxxxxx>
> wrote:
> > > >
> > > >> Hi Ruphine,
> > > >>
> > > >> Have you been able to fix the problem with your PR?
> > > >>
> > > >> If there are still problems, maybe you should create another issue
> and
> > > >> clearly explain the error you are having so others can take a look
> at
> > > it.
> > > >> Also, you might want to pull in Mark's latest commit and see if that
> > > will
> > > >> solve the problem.
> > > >>
> > > >> On Thu, Oct 25, 2018 at 9:53 AM Ruphine Kengne <
> > ruphinekengne@xxxxxxxxx
> > > >
> > > >> wrote:
> > > >>
> > > >> > Hello Mark,
> > > >> >
> > > >> > Thanks very much for your quick reply.
> > > >> >
> > > >> > Here is the link to the PR having the error:
> > > >> > https://github.com/apache/fineract-cn-fims-web-app/pull/12
> > > >> >
> > > >> > I have added the MatSelectModule into the imports of the
> > TestingModule
> > > >> but
> > > >> > I still have the same error after running the test.
> > > >> >
> > > >> > Thanks
> > > >> > Ruphine Kengne
> > > >> >
> > > >> >
> > > >> > On Thu, 25 Oct 2018 at 09:27, Mark van Veen <
> mark.vanveen@xxxxxxxxx
> > >
> > > >> > wrote:
> > > >> >
> > > >> > > It looks like the test in available-actions.service.spec.ts does
> > > pull
> > > >> in
> > > >> > a
> > > >> > > component which is using the MatSelect component. This is weird
> > > since
> > > >> > its a
> > > >> > > unit test for a service which should not have any references to
> a
> > > >> > component
> > > >> > > itself.
> > > >> > >
> > > >> > > Do you have a branch/fork/PR to share? So I can have a look and
> > add
> > > my
> > > >> > > comments.
> > > >> > >
> > > >> > > BTW - the solution would be to add the MatSelectModule into the
> > > >> imports
> > > >> > of
> > > >> > > the TestingModule but it would be good to understand why the
> > > >> component is
> > > >> > > being pulled in first.
> > > >> > >
> > > >> > > On Mon, Oct 22, 2018 at 7:09 PM Ruphine Kengne <
> > > >> ruphinekengne@xxxxxxxxx>
> > > >> > > wrote:
> > > >> > >
> > > >> > > > Hello everyone,
> > > >> > > >
> > > >> > > > I wrote unit test for the Group service into fims-web-app, it
> > > worked
> > > >> > > > successful
> > > >> > > > but I am having an error from the AvailableActionService in
> the
> > > >> teller
> > > >> > > > service when I run npm run test.
> > > >> > > >
> > > >> > > > Here is the link to the error:
> > > >> > > > https://pastebin.com/9ftKYDg8
> > > >> > > >
> > > >> > > > Here is the link to the commit for the issue FINCN-100(Write
> > Unit
> > > >> test
> > > >> > > for
> > > >> > > > the Group service into fims):
> > > >> > > >
> > > >> > > >
> > > >> > >
> > > >> >
> > > >>
> > >
> >
> https://github.com/kengneruphine/fineract-cn-fims-web-app/commit/a2355be72c8bbd0cdfc86a6fdbdeb8d9be5c2f99
> > > >> > > >
> > > >> > > > Please can someone help me out?
> > > >> > > >
> > > >> > > > Thanks
> > > >> > > > Ruphine Kengne
> > > >> > > >
> > > >> > >
> > > >> >
> > > >>
> > > >
> > >
> >
>