git.net

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Druid PR review checklist


A lot of new committers are expected to enter the projects with rights to
review and merge PRs.

I suggest to create a PR review checklist to help new (and old!) reviewers
(and PR authors, for self-review before even publishing a PR) not to forget
something.

I think a PR (because it's not editable by many people) or a Wiki page
(because it's not commentable) on Github is not an ideal form of
collaboration for creating an original version of such document, so I
created a Google document (commentable, editable):
https://docs.google.com/document/d/17EEKT6fih9Dd5NfXjBoECcKbVp1eOB2vb3jKqTF9pPc/edit?usp=sharing

Developers are welcome to add comments and list things that they look at
when doing reviews.

Note: the list is going to be huge and people are not realistically
expected to pedantically follow all of it's items on every PR review, but
IMO such "gold standard" should help to keep the quality of reviews high.