git.net

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[GitHub] asdf2014 commented on a change in pull request #5980: Various changes about druid-services module


asdf2014 commented on a change in pull request #5980: Various changes about druid-services module
URL: https://github.com/apache/incubator-druid/pull/5980#discussion_r201398587
 
 

 ##########
 File path: services/src/main/java/io/druid/cli/CliCoordinator.java
 ##########
 @@ -255,6 +255,6 @@ public LoadQueueTaskMaster getLoadQueueTaskMaster(
 
   public static boolean isOverlord(Properties properties)
   {
-    return Boolean.valueOf(properties.getProperty("druid.coordinator.asOverlord.enabled")).booleanValue();
+    return Boolean.valueOf(properties.getProperty("druid.coordinator.asOverlord.enabled"));
 
 Review comment:
   There is no need for the `.booleanValue()` method, cuz Java will automatically unbox `Boolean` primitive after JDK 5+.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@xxxxxxxxxxxxxxxx


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@xxxxxxxxxxxxxxxx
For additional commands, e-mail: dev-help@xxxxxxxxxxxxxxxx




( ! ) Warning: include(msgfooter.php): failed to open stream: No such file or directory in /var/www/git/apache-druid-developers/msg00472.html on line 103
Call Stack
#TimeMemoryFunctionLocation
10.0006364632{main}( ).../msg00472.html:0

( ! ) Warning: include(): Failed opening 'msgfooter.php' for inclusion (include_path='.:/var/www/git') in /var/www/git/apache-druid-developers/msg00472.html on line 103
Call Stack
#TimeMemoryFunctionLocation
10.0006364632{main}( ).../msg00472.html:0