git.net

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[GitHub] jihoonson commented on a change in pull request #5980: Various changes about druid-services module


jihoonson commented on a change in pull request #5980: Various changes about druid-services module
URL: https://github.com/apache/incubator-druid/pull/5980#discussion_r201152064
 
 

 ##########
 File path: services/src/main/java/io/druid/cli/CreateTables.java
 ##########
 @@ -74,40 +73,35 @@ public CreateTables()
         new DruidProcessingModule(),
         new QueryableModule(),
         new QueryRunnerFactoryModule(),
-        new Module()
-        {
-          @Override
-          public void configure(Binder binder)
-          {
-            JsonConfigProvider.bindInstance(
-                binder, Key.get(MetadataStorageConnectorConfig.class), new MetadataStorageConnectorConfig()
+        binder -> {
+          JsonConfigProvider.bindInstance(
+              binder, Key.get(MetadataStorageConnectorConfig.class), new MetadataStorageConnectorConfig()
 
 Review comment:
   Please break the line per comma like below:
   
   ```
   binder, 
   Key.get(MetadataStorageConnectorConfig.class), 
   new MetadataStorageConnectorConfig()
   {
   }
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@xxxxxxxxxxxxxxxx


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@xxxxxxxxxxxxxxxx
For additional commands, e-mail: dev-help@xxxxxxxxxxxxxxxx




( ! ) Warning: include(msgfooter.php): failed to open stream: No such file or directory in /var/www/git/apache-druid-developers/msg00422.html on line 119
Call Stack
#TimeMemoryFunctionLocation
10.0006364632{main}( ).../msg00422.html:0

( ! ) Warning: include(): Failed opening 'msgfooter.php' for inclusion (include_path='.:/var/www/git') in /var/www/git/apache-druid-developers/msg00422.html on line 119
Call Stack
#TimeMemoryFunctionLocation
10.0006364632{main}( ).../msg00422.html:0