git.net

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[GitHub] stevedlawrence commented on a change in pull request #77: Modifications to IO layer to support streaming input data


stevedlawrence commented on a change in pull request #77: Modifications to IO layer to support streaming input data
URL: https://github.com/apache/incubator-daffodil/pull/77#discussion_r201095086
 
 

 ##########
 File path: daffodil-io/src/main/scala/org/apache/daffodil/io/ByteBufferDataInputStream.scala
 ##########
 @@ -1,1270 +0,0 @@
-/*
 
 Review comment:
   This file is removed in this diff. It's all removals.
   
   Regarding the two implements, there are two implementations of InputSource's in InputSource.scala. There's the BucketingInputSource which implements the bucketing algorithm, and a ByteBufferInputSource which just reads data out of a ByteBuffer. There's no bucketing there, so it should be more efficient if someone already has data in an array or byte buffer, The downside is that we cannot free up data from a ByteBuffer so it might waste memory. That's also limited to 2GB because of Java. The BucketingInputSource has a much higher limit of MaxInt * bucketSize.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@xxxxxxxxxxxxxxxx


With regards,
Apache Git Services