git.net

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[GitHub] mbeckerle commented on a change in pull request #77: Modifications to IO layer to support streaming input data


mbeckerle commented on a change in pull request #77: Modifications to IO layer to support streaming input data
URL: https://github.com/apache/incubator-daffodil/pull/77#discussion_r201027993
 
 

 ##########
 File path: daffodil-io/src/main/scala/org/apache/daffodil/io/ByteBufferDataInputStream.scala
 ##########
 @@ -1,1270 +0,0 @@
-/*
 
 Review comment:
   Remove entire file.
   
   Note that your description of the PR suggests that there are still two implementations here, one of byte buffers, one with input streams, but this file seems to be entirely gone. Is the byte buffer one elsewhere?
   
   Nevermind. I found that the byte buffer implementation just uses the bucketing one, but passes a ByteBufferInputStream created from the byte buffer. That's the right thing. This file should be entirely deleted. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@xxxxxxxxxxxxxxxx


With regards,
Apache Git Services