git.net

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[GitHub] stevedlawrence commented on a change in pull request #70: Adding property binaryCalendarRep with values "binarySeconds" and "bi…


stevedlawrence commented on a change in pull request #70: Adding property binaryCalendarRep with values "binarySeconds" and "bi…
URL: https://github.com/apache/incubator-daffodil/pull/70#discussion_r190866467
 
 

 ##########
 File path: daffodil-test-ibm1/src/test/resources/test-suite/ibm-contributed/dpaext2.tdml
 ##########
 @@ -327,7 +327,7 @@
 		<document><documentPart type="byte">000000000000003C</documentPart></document>
 		<infoset>
 			<dfdlInfoset xmlns:xs="http://www.w3.org/2001/XMLSchema"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";>
-			  <testBinaryMilliseconds xsi:type="xs:dateTime">2009-12-24T05:15:00.060000+05:00</testBinaryMilliseconds>
+			  <testBinaryMilliseconds xsi:type="xs:dateTime">2009-12-24T05:15:00.060000+00:00</testBinaryMilliseconds>
 
 Review comment:
   Interesting. The original test had a binaryCalendarEpoch in the +5 timezone, and so the expected infoset value was in the +5 timezone. I would expect that the output should be in the timezone of the dfdl:calendarTimeZone property. This is because with binaryCalendarSec/MilSec no timezone is in the data, and the dfdl:calendarTimeZone property says: This property provides the time zone that will be assumed if no time zone explicitly occurs in the data. Seems like the test was wrong, and even if dfdl:binaryCalendarEpoch includes a timezone, it shouldn't affect the infoset timezone. Thoughts?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@xxxxxxxxxxxxxxxx


With regards,
Apache Git Services