git.net

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[GitHub] stevedlawrence commented on a change in pull request #68: Fix so trace works even when layering is being used.


stevedlawrence commented on a change in pull request #68: Fix so trace works even when layering is being used.
URL: https://github.com/apache/incubator-daffodil/pull/68#discussion_r186478058
 
 

 ##########
 File path: daffodil-io/src/main/scala/org/apache/daffodil/io/DataOutputStreamImplMixin.scala
 ##########
 @@ -816,7 +816,7 @@ trait DataOutputStreamImplMixin extends DataStreamCommonState
   }
 
   final override def pastData(nBytesRequested: Int): ByteBuffer = {
-    Assert.usage(isReadable)
+    Assert.usage(isReadable || areDebugging)
     if (!areDebugging)
       throw new IllegalStateException("Must be debugging.")
 
 Review comment:
   It's now impossible to hit this IllegalStateException. Note that the parse past/futureData functions do not have an assert but just have the if (!artDebugging) check. Should these all behave similarly, or are there reasons for the differences?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@xxxxxxxxxxxxxxxx


With regards,
Apache Git Services