git.net

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[GitHub] mbeckerle commented on a change in pull request #61: Preliminary Review - Base64 layering runs first parsing unit test.


mbeckerle commented on a change in pull request #61: Preliminary Review - Base64 layering runs first parsing unit test.
URL: https://github.com/apache/incubator-daffodil/pull/61#discussion_r183101705
 
 

 ##########
 File path: daffodil-core/src/test/scala/org/apache/daffodil/layers/TestLayers.scala
 ##########
 @@ -38,7 +38,7 @@ class TestLayers {
       <dfdl:format ref="tns:GeneralFormat"/>,
       <xs:element name="e1" dfdl:lengthKind="implicit">
         <xs:complexType>
-          <xs:sequence dfdl:layerTransform="base64_MIME" dfdl:layerLengthKind="delimited" dfdl:layerTerminator="!" dfdl:layerEncoding="iso-8859-1">
+          <xs:sequence dfdl:layerTransform="base64_MIME" dfdl:layerLengthKind="delimited" dfdl:layerBoundaryMark="!" dfdl:layerEncoding="iso-8859-1">
 
 Review comment:
   Yes, I removed the discussion of parent delimiting markup having impact. 
   
   I like changing the layerLengthKind to boundaryMark also. Will make that change. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@xxxxxxxxxxxxxxxx


With regards,
Apache Git Services