git.net

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [VOTE] Release Apache Commons Imaging 1.0-alpha1 based on RC2


On Fri, Nov 2, 2018 at 9:32 AM Gary Gregory <garydgregory@xxxxxxxxx> wrote:

> When I run the build on Java 8, I get Javadoc errors and using
> -P jdk8-javadoc does not seem to turn doclint off. Can anyone get the build
> to work on Java 8?
>

-1 due to failure of 'mvn apache-rat:check':

4 Unknown Licenses

*****************************************************

Files with unapproved licenses:

  src/test/data/images/pbm/1/Oregon Scientific DS6639 - DSC_0307 - small.pbm
  src/test/data/images/pbm/1/Oregon Scientific DS6639 - DSC_0307 - small.ppm
  src/test/data/images/pbm/2/5x5-rgb-alpha.pam
  src/test/data/images/pbm/2/5x5-rgb.pam

If these files are TRULY OK and not encumbered with an incompatible
license, they need to be excluded from the RAT report.

Moving on to using Java 7 and the src zip: ASC, SHA256, SHA512 OK.

Building with 'set MAVEN_OPTS=-XX:MaxPermSize=128m' and 'mvn clean package
site' and:

Apache Maven 3.6.0 (97c98ec64a1fdfee7767ce5ffb20918da4f719f3;
2018-10-24T12:41:47-06:00)
Maven home: C:\Java\apache-maven-3.6.0\bin\..
Java version: 1.7.0_80, vendor: Oracle Corporation, runtime: C:\Program
Files\Java\jdk1.7.0_80\jre
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 8.1", version: "6.3", arch: "amd64", family: "windows"

After this Alpha release, I propose we make the Java requirement Java 8.

Building shows:

[ERROR] Error downloading issues from JIRA. Cause is Received fatal alert:
protocol_version

Does a plugin need an update? The JIRA report is empty for me but I see
that your site has it generated, so this is something with my setup...

*TODO*: Update the changes.xml file to carry version 1.0-alpha1 instead of
1.0.

Other reports seem no worse than before.

Gary


> Gary
>
> On Wed, Oct 31, 2018 at 11:06 AM Andreas Lehmkuehler <andreas@xxxxxxxx>
> wrote:
>
>> Am 30.10.18 um 10:09 schrieb Bruno P. Kinoshita:
>> > We have fixed quite a few bugs and added some significant enhancements
>> since Apache Sanselan Incubating 0.97-incubator was released, so I would
>> like to release Apache Commons Imaging 1.0-alpha1.
>> >
>> > Apache Commons Imaging 1.0-alpha1 RC2 is available for review here:
>> > https://dist.apache.org/repos/dist/dev/commons/imaging/1.0-alpha1-RC2
>> (svn revision 30516)
>> >
>> > The Git tag commons-imaging-1.0-alpha1-RC2 commit for this RC is
>> e4e1b4dd0da6d4c90205674a730738576f2bee8e which you can browse here:
>> >
>> https://git-wip-us.apache.org/repos/asf?p=commons-imaging.git;a=tag;h=refs/tags/commons-imaging-1.0-alpha1-RC2
>> >
>> > Maven artifacts are here:
>> >
>> >
>> https://repository.apache.org/content/repositories/orgapachecommons-1395/org/apache/commons/commons-imaging/1.0-alpha1/
>> >
>> > These are the Maven artifacts and their hashes in Nexus:
>> >
>> > #Release SHA-256s
>> > #Tue Oct 30 21:27:02 NZDT 2018
>> >
>> commons-imaging-1.0-alpha1-sources-java-source=c5a359c19f7768860a520b4e37aecd0bf9e7b95665d45c3bddedac10ea83aca1
>> >
>> commons-imaging-1.0-alpha1-bin-zip=3eeb5894c91975524e6e858b8d9318ef69faf2b7c1c37157783897ececf9339f
>> >
>> commons-imaging-1.0-alpha1-sources-jar.asc=0c1c298db3ead3069e221b9bbb153702819d1be0c90982bd7bc31384d4dadf7a
>> >
>> commons-imaging-1.0-alpha1-src-zip.asc=3c2aa29c8ac1d0cc036821cf2d2c7647a3d08aadad7f156c67df92c1336ad14a
>> >
>> commons-imaging-1.0-alpha1-pom.asc=aa33dacce18d8bcd2f90827f78907615c5f1ea0f56af9a77df9dfb29f4a10542
>> >
>> commons-imaging-1.0-alpha1-tests-jar.asc=4a7fe21a8c85e00b53eae6de8ccc138c7d0d7655af5d34d866196f3992a44b2f
>> >
>> commons-imaging-1.0-alpha1-javadoc-jar.asc=ff15ecc262d47fb8551f99adcb2a7f259180c5c54763bf7b2f51c16470ff0034
>> >
>> commons-imaging-1.0-alpha1-tests-test-jar=520eb1223a59bcc9c14c553acc58e1e4258574f9caaf0797093698a4fa2130c0
>> >
>> commons-imaging-1.0-alpha1-jar.asc=28957df1acd3c3a6fb7326f03b8115a3b2d760de07d3f9b8cc6722d7af98508a
>> >
>> commons-imaging-1.0-alpha1-bin-tar.gz.asc=415d3753f9be590f0e0be829f3499d14e2c42c2bd39deddb9a8ab538b3d2327f
>> >
>> commons-imaging-1.0-alpha1-test-sources-jar.asc=cc085db20953597090b40084362e523cd52faa2fc535ef83b083fde08559762d
>> >
>> commons-imaging-1.0-alpha1-src-tar.gz=486c71ef3d7ca3760dcece77c5c8979dc544270d60f21d0994725cb1aa3a04fd
>> >
>> commons-imaging-1.0-alpha1-bin-zip.asc=ef67c0c3795ebecc6567c7e7b75cf4797f5b7d5c7387b87ac6703157c88029a9
>> >
>> commons-imaging-1.0-alpha1-javadoc-javadoc=37feb9395af4d17ad7407b3deb95e8c4001acb6b42d790eb20acf3ddb8b4851b
>> >
>> commons-imaging-1.0-alpha1-src-zip=180a29bd5ff95b5c32ec62a0a0949d68ff9907e18740c793266de0bd6dc2f8b7
>> >
>> commons-imaging-1.0-alpha1-bin-tar.gz=73c5324e87e81f9c837c3403f133f6dc112d07f0b3ee6bbb758b3701aa8b23a4
>> >
>> commons-imaging-1.0-alpha1-test-sources-java-source=91d26c80147a539652cd1acb3aae2f550ee848f9f0cecf640e3916075778df2f
>> >
>> commons-imaging-1.0-alpha1-src-tar.gz.asc=166477b4d91b51b8d5295346e697ca0f3c75b3f3f7ba06e67fea9c2d523bb061
>> >
>> > #Release SHA-512s
>> > #Tue Oct 30 21:27:02 NZDT 2018
>> >
>> commons-imaging-1.0-alpha1-sources-java-source=eb0c088ec3482a60bab4a806688faa4ef955eb3099a8cbb321226ea527b9f87d176fc9f4cf4243795ec8f9b2c8ed5ab6b021b737c32fd0708e2d24a9aca6f5d0
>> >
>> commons-imaging-1.0-alpha1-bin-zip=8c1bf5a1d4cd1423bc1153f505493ebf8c235d2e550dc01bb77d937392e05a814b7928355a3400fe02bdfa2ae7cc9d94aec572cd35c27a47f16acd56f4c0e95b
>> >
>> commons-imaging-1.0-alpha1-sources-jar.asc=048ef87ebc5dee2fc25353e71b79f07f5fa1b96cad65f6b6aa19e4b78d669fefe9cad36a269f6ec0ff23af0b2a591a18d2ea7769c0c3857ec3f70cc33cad2c24
>> >
>> commons-imaging-1.0-alpha1-src-zip.asc=584160a22dc44e2adb70c01d4cf7c8f0156bf4c27d92dea9c27a0740e406331456572ed48c4ce79ef1c4ed366097c0a4e67c5f7753f6be6bfdc34149d1bf8eeb
>> >
>> commons-imaging-1.0-alpha1-pom.asc=648a2929ee3319bfa204c9e8e5cc55d23ad8789bd4d6d4eab8715b718d1074e89688431188017df94e27f40bf954f814a2fde6a29e13a34b6dd5eb1fd4da223d
>> >
>> commons-imaging-1.0-alpha1-tests-jar.asc=e28ae8f2df7d178b712172170d5a791a07f8ad0f3a7820bc737365344d2e0f7ca68d976ca01ffaa00023e7ed99a029f3fb7f457a61cd16812b5d28f363ed3429
>> >
>> commons-imaging-1.0-alpha1-javadoc-jar.asc=62423db7b7f9715650c5324831cb049d66ee8692db8cd7654eefd110291bb52cec607cb3a1dbf5c09415f5390636f43811da4e457698befe7ff912055d4d419f
>> >
>> commons-imaging-1.0-alpha1-tests-test-jar=375e4b6a1dd6a631d16161957d0cad6641382906f558ea54209fa8259d16395fba67eeda9115adb7b4204b5c8802309f3899adc7e456a459e25359e8abba3ca1
>> >
>> commons-imaging-1.0-alpha1-jar.asc=c51bbeff8de1a78a64bdedff5e4a6db44034d8fc9eec2c0e70527f090341a7789c1ab0048f790560b7086295204e885ba0e175e35b705f8eccc59d9404df323a
>> >
>> commons-imaging-1.0-alpha1-bin-tar.gz.asc=dfc503a8b9e5672c1e444f460f02de142d12c6f321531a02ec7d1b1b67212a5014e35fe84fdc9575e8de9d5f03901916149ba7ac7ff51ae5b8fa5bff026f0c54
>> >
>> commons-imaging-1.0-alpha1-test-sources-jar.asc=a4b2ee4883409c498152689ec4024b627fc129d4614cfe0e1241d416cd43dfe10d365d8364260f6e14ba85e708e19b800ec88560a844499eab8f2b5d4f3fd3db
>> >
>> commons-imaging-1.0-alpha1-src-tar.gz=32c6f6d5db016d4a96a82e0f0dd63a884b9d2a4199e30b8ab6c1d5761f72d3060c7d1d9c02d697fbba054f07023bf155b65f8b745414438884df822657212614
>> >
>> commons-imaging-1.0-alpha1-bin-zip.asc=c6869704d9d4b4a826663aef7667c38a580b5e7254c8ac1576018fff72fa73e94bd85c3e043e323f42909c66fb94ad0192bf41c1d016229bb35da57e0c77c6af
>> >
>> commons-imaging-1.0-alpha1-javadoc-javadoc=b2aa22818e46d1ab866ca25dd6cd93aa6ac7062dde5742cc37eb67479a14c187d68369fb9a099140d25c6857eb1b45b42a22e2b249cce88103856c9ff9eed1a5
>> >
>> commons-imaging-1.0-alpha1-src-zip=f5a732c874b1763469d9638fb6fac614b4ad5c07c2a73e7d67e835b63d8844af83486f02968fb40f2e9cafd07b2b4ed213275364afabb23ea0e149fb7e3bbf07
>> >
>> commons-imaging-1.0-alpha1-bin-tar.gz=ada169558080805f8da065a9509a7d53f2f9c964fb523761b66f47caf35139dea4caf2b0ef9f549b7010551f0a7ce94a7e92f73eb28bfcb1f1244c67459eb949
>> >
>> commons-imaging-1.0-alpha1-test-sources-java-source=8a9dd5a25ccd762c3eaf4a9652675f8e5c8b12020c7f2497685e73a53f60c21ea55467920d1c595cf26fb9f4dcf579ef92fde5fb59de396b7cfb5277e5cdc980
>> >
>> commons-imaging-1.0-alpha1-src-tar.gz.asc=4e97e74f2de9b22c6f05018ab50ba088f9a53cfd29da8f7b2cf480fe4a8f15bd4c60ec20cbdc250fc15e20be5390d56b94f04eecdc7761f7325e1b51380b7ba8
>> >
>> >
>> > (no need for .asc hashes!)
>> >
>> > I have tested this with ***'mvn clean install site'*** using:
>> >
>> > Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe;
>> 2018-06-18T06:33:14+12:00)
>> > Maven home: /opt/apache-maven-3.5.4
>> > Java version: 1.8.0_181, vendor: Oracle Corporation, runtime:
>> /usr/lib/jvm/java-8-openjdk-amd64/jre
>> > Default locale: en_NZ, platform encoding: UTF-8
>> > OS name: "linux", version: "4.15.0-38-generic", arch: "amd64", family:
>> "unix"
>>
>>
>> I'm using the following environment:
>>
>> Apache Maven 3.5.2 (Red Hat 3.5.2-5)
>> Maven home: /usr/share/maven
>> Java version: 1.8.0_181, vendor: Oracle Corporation
>> Java home: /usr/lib/jvm/java-1.8.0-openjdk-1.8.0.181.b15-6.fc28.x86_64/jre
>> Default locale: de_DE, platform encoding: UTF-8
>> OS name: "linux", version: "4.18.16-200.fc28.x86_64", arch: "amd64",
>> family: "unix"
>>
>> "mvn clean install" works without any issues
>>
>> If I try to build the javadocs using "mvn clean install site" I got a lot
>> of
>> warnings and errors like the following:
>>
>> [ERROR]
>> /home/lehmi/workspace/source/release/commons-imaging/src/main/java/org/apache/commons/imaging/Imaging.java:142:
>>
>> error: semicolon missing
>> [ERROR]      * (for example "&#46jpg", "&#46;gif", "&#46;png", etc&#46;).
>> [ERROR]                      ^
>> [ERROR]
>> /home/lehmi/workspace/source/release/commons-imaging/src/main/java/org/apache/commons/imaging/Imaging.java:159:
>>
>> error: semicolon missing
>> [ERROR]      * (for example "&#46jpg", "&#46;gif", "&#46;png", etc&#46;).
>> [ERROR]                      ^
>> [ERROR]
>> /home/lehmi/workspace/source/release/commons-imaging/src/main/java/org/apache/commons/imaging/Imaging.java:198:
>>
>> warning: no @throws for org.apache.commons.imaging.ImageReadException
>> [ERROR]     public static ImageFormat guessFormat(final byte[] bytes)
>> [ERROR]                               ^
>> [ERROR]
>> /home/lehmi/workspace/source/release/commons-imaging/src/main/java/org/apache/commons/imaging/Imaging.java:198:
>>
>> warning: no @throws for java.io.IOException
>> [ERROR]     public static ImageFormat guessFormat(final byte[] bytes)
>> [ERROR]                               ^
>> [ERROR]
>> /home/lehmi/workspace/source/release/commons-imaging/src/main/java/org/apache/commons/imaging/Imaging.java:218:
>>
>> warning: no @throws for org.apache.commons.imaging.ImageReadException
>>
>> Maybe this is just related to my environment or am I missing some
>> parameter?
>>
>> IMHO this is a minor issue for a RC version
>>
>> [x] +1 Release these artifacts
>>
>>
>> Thanks for cutting the more than overdue release!!
>>
>> Andreas
>>
>> >
>> > Details of changes since 0.97-incubator are in the release notes:
>> >
>> https://dist.apache.org/repos/dist/dev/commons/imaging/1.0-alpha1-RC2/RELEASE-NOTES.txt
>> >
>> https://dist.apache.org/repos/dist/dev/commons/imaging/1.0-alpha1-RC2/site/changes-report.html
>> >
>> > Site:
>> >
>> https://dist.apache.org/repos/dist/dev/commons/imaging/1.0-alpha1-RC2/site
>> > (note some *relative* links are broken and the 1.0-alpha1 directories
>> are not yet created - these will be OK once the site is deployed.)
>> >
>> > JApiCmp Report (compared to 1.5):
>> >
>> https://dist.apache.org/repos/dist/dev/commons/imaging/1.0-alpha1-RC2/site/japicmp.html
>> >
>> > Skipped Clirr as this is the first release of this component, with new
>> package and classes names.
>> >
>> > RAT Report:
>> >
>> https://dist.apache.org/repos/dist/dev/commons/imaging/1.0-alpha1-RC2/site/rat-report.html
>> >
>> > KEYS:
>> > https://www.apache.org/dist/commons/KEYS
>> >
>> > Please review the release candidate and vote.
>> > This vote will close no sooner that 72 hours from now.
>> >
>> > [ ] +1 Release these artifacts
>> > [ ] +0 OK, but...
>> > [ ] -0 OK, but really should fix...
>> > [ ] -1 I oppose this release because...
>> >
>> > Thank you,
>> >
>> > Bruno P. Kinoshita,
>> > Release Manager (using key 33C6E01240C5468C2B7A556954E2764B48A42DF0)
>> >
>> > ---------------------------------------------------------------------
>> > To unsubscribe, e-mail: dev-unsubscribe@xxxxxxxxxxxxxxxxxx
>> > For additional commands, e-mail: dev-help@xxxxxxxxxxxxxxxxxx
>> >
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@xxxxxxxxxxxxxxxxxx
>> For additional commands, e-mail: dev-help@xxxxxxxxxxxxxxxxxx
>>
>>