git.net

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [All] CP definitions (Was: svn commit: r1841296 [...])


Hello,

Reverting this change was discussed here [1]. It was a result of this
commit [2] breaking multiple component builds. As Stefan points out the
initial change does not make sense, since the componentId is always just
the name without "commons-" (e.g. math4). But the folders for all the
websites have the commons prefix (e.g. commons-math).

I just restored the old (working) behavior. I'm fine with making things
easier/more straight forward. But let's make sure that all the other
components still work.

Regards,
Benedikt

[1]
https://lists.apache.org/thread.html/304129bf7d25a2118ee3f324214c04e1e8f0846e7ee43a57b100a26e@%3Cdev.commons.apache.org%3E
[2]
http://svn.apache.org/viewvc/commons/proper/commons-parent/trunk/pom.xml?r1=1831599&r2=1832339

Am Mi., 19. Sep. 2018 um 17:25 Uhr schrieb Gary Gregory <
garydgregory@xxxxxxxxx>:

> On Wed, Sep 19, 2018 at 8:30 AM Rob Tompkins <chtompki@xxxxxxxxx> wrote:
>
> > I think the plan moving forward here is that we should do the following:
> >
> > <commons.componentid>math</commons.componentid>
> > <commons.packageId>math4</commons.pachageId>
> >
> > And change [parent] back to
> >
> > <commons.scmPubUrl>
> >
> https://svn.apache.org/repos/infra/websites/production/commons/content/proper/${commons.componentid}
> > </commons.scmPubUrl>
> >
> > Yeah?
> >
>
> LGTM.
>
> Gary
>
>
> >
> > -Rob
> >
> > > On Sep 19, 2018, at 9:36 AM, Rob Tompkins <chtompki@xxxxxxxxx> wrote:
> > >
> > >
> > >
> > >> On Sep 19, 2018, at 9:28 AM, Gilles <gilles@xxxxxxxxxxxxxxxxxxxxx>
> > wrote:
> > >>
> > >>> On Wed, 19 Sep 2018 06:45:13 -0600, Gary Gregory wrote:
> > >>> The difference is to account for artifact ids that contain a version
> > like
> > >>> commons-lang3. The component id is then just commons-lang. You must
> not
> > >>> have versions in names for certain names like in the download page.
> > This
> > >>> change will probably break builds like pool, dbcp, lang, and so on.
> > >>
> > >> Hmm, this completes the confusion!
> > >>
> > >> If "artifactId" is e.g. commons-lang3 then I don't understand how
> > >> the reverted line works because (AFAICT) the SVN URL is
> > >>
> >
> https://svn.apache.org/repos/infra/websites/production/commons/content/proper/commons-lang/
> > >>
> > >> The [Math] POM contains these lines:
> > >> ---CUT---
> > >>   <!-- Do not change: "math" is the name of the component even if the
> > >>        name of the base package evolves with major release numbers
> > >>        (see "commons.osgi.symbolicName", below). -->
> > >>   <commons.componentid>math4</commons.componentid>
> > >> ---CUT---
> > >> Correct or not?
> > >
> > > Half of the components are correct, half aren’t.
> > >
> > > What’s the consensus here? My thought was that componentId=math is
> > actually correct based on the documentation, and we need and
> > “artifactIdSuffix” or something analogous.
> > >
> > > -Rob
> > >
> > >>
> > >> It also uses a fix string:
> > >> ---CUT---
> > >> <commons.scmPubUrl>
> >
> https://svn.apache.org/repos/infra/websites/production/commons/content/proper/commons-math
> > </commons.scmPubUrl>
> > >> ---CUT---
> > >> whereas a variable (as in the commit below) would seem more portable.
> > >>
> > >> Why isn't "<commons.scmPubUrl>" defined in CP only (using the
> > appropriate
> > >> variable overridden in each component)?
> > >>
> > >> Why having
> > >> ---CUT---
> > >> <commons.site.path>math</commons.site.path>
> > >> ---CUT---
> > >> that doesn't look at all like a "path"?
> > >> We could define a quite more explicit "<commons.component.name>"
> > >> that could serve for composing a path, as well as for any
> > >> other purpose where the component is meant, independently
> > >> of artefact identifier syntax or major version.
> > >>
> > >>
> > >> Regards,
> > >> Gilles
> > >>
> > >>> Gary
> > >>>
> > >>>> On Wed, Sep 19, 2018, 04:07 Gilles <gilles@xxxxxxxxxxxxxxxxxxxxx>
> > wrote:
> > >>>>
> > >>>> Hi.
> > >>>>
> > >>>> Are we sure that the fix/revert below to work as intended for
> > >>>> *all* components?
> > >>>>
> > >>>> Common usage should be enforced (e.g. to allow anyone to help
> > >>>> releasing any component), and ancient inconsistencies fixed.
> > >>>>
> > >>>> With a concrete example of a component that has had major
> > >>>> version changes (and top-level package change accordingly),
> > >>>> what is
> > >>>> commons.componentid
> > >>>> and what is
> > >>>> project.artefactId
> > >>>> ?
> > >>>>
> > >>>> Thanks,
> > >>>> Gilles
> > >>>>
> > >>>> On Wed, 19 Sep 2018 08:06:17 -0000, britter@xxxxxxxxxx wrote:
> > >>>>> Author: britter
> > >>>>> Date: Wed Sep 19 08:06:17 2018
> > >>>>> New Revision: 1841296
> > >>>>>
> > >>>>> URL: http://svn.apache.org/viewvc?rev=1841296&view=rev
> > >>>>> Log:
> > >>>>> COMMONSSITE-124: Revert change in commons.scmPubUrl in Parent 47
> > >>>>>
> > >>>>> Modified:
> > >>>>>    commons/proper/commons-parent/trunk/pom.xml
> > >>>>>    commons/proper/commons-parent/trunk/src/changes/changes.xml
> > >>>>>
> > >>>>> Modified: commons/proper/commons-parent/trunk/pom.xml
> > >>>>> URL:
> > >>>>>
> > >>>>>
> > >>>>
> >
> http://svn.apache.org/viewvc/commons/proper/commons-parent/trunk/pom.xml?rev=1841296&r1=1841295&r2=1841296&view=diff
> > >>>>>
> > >>>>>
> > >>>>
> >
> ==============================================================================
> > >>>>> --- commons/proper/commons-parent/trunk/pom.xml (original)
> > >>>>> +++ commons/proper/commons-parent/trunk/pom.xml Wed Sep 19 08:06:17
> > >>>>> 2018
> > >>>>> @@ -1940,7 +1940,7 @@
> > >>>>>     <!-- value modules can override it -->
> > >>>>>     <commons.site.path>${commons.componentid}</commons.site.path>
> > >>>>>
> > >>>>> -
> > >>>>>
> > >>>>> <commons.scmPubUrl>
> > >>>>
> >
> https://svn.apache.org/repos/infra/websites/production/commons/content/proper/${commons.componentid}
> > >>>> </commons.scmPubUrl>
> > >>>>> +
> > >>>>>
> > >>>>> <commons.scmPubUrl>
> > >>>>
> >
> https://svn.apache.org/repos/infra/websites/production/commons/content/proper/${project.artifactId}
> > >>>> </commons.scmPubUrl>
> > >>>>>
> > >>>>>
> > >>>>>
> > >>>>
> >
> <commons.scmPubCheckoutDirectory>${commons.site.cache}/${commons.site.path}</commons.scmPubCheckoutDirectory>
> > >>>>>     <commons.scmPubServer>commons.site</commons.scmPubServer>
> > >>>>>
> > >>>>>
> > >>>>> Modified:
> commons/proper/commons-parent/trunk/src/changes/changes.xml
> > >>>>> URL:
> > >>>>>
> > >>>>>
> > >>>>
> >
> http://svn.apache.org/viewvc/commons/proper/commons-parent/trunk/src/changes/changes.xml?rev=1841296&r1=1841295&r2=1841296&view=diff
> > >>>>>
> > >>>>>
> > >>>>
> >
> ==============================================================================
> > >>>>> --- commons/proper/commons-parent/trunk/src/changes/changes.xml
> > >>>>> (original)
> > >>>>> +++ commons/proper/commons-parent/trunk/src/changes/changes.xml Wed
> > >>>>> Sep 19 08:06:17 2018
> > >>>>> @@ -61,6 +61,7 @@ The <action> type attribute can be add,u
> > >>>>>     <body>
> > >>>>>
> > >>>>>         <release version="48" date="YYYY-MM-DD" description="TBD">
> > >>>>> +            <action issue="COMMONSSITE-124" type="fix"
> > >>>>> dev="britter">Revert change in commons.scmPubUrl in Parent
> > >>>>> 47</action>
> > >>>>>             <action type="update">Update parent from
> > >>>>> org.apache:apache 19 to 20.</action>
> > >>>>>             <action type="update">maven-compiler-plugin 3.7.0 ->
> > >>>>> 3.8.0</action>
> > >>>>>             <action type="fix">re-enabled japicmp and introduced
> > >>>>> japicmp.skip property that
> > >>>>
> > >>>>
> > >>>>
> ---------------------------------------------------------------------
> > >>>> To unsubscribe, e-mail: dev-unsubscribe@xxxxxxxxxxxxxxxxxx
> > >>>> For additional commands, e-mail: dev-help@xxxxxxxxxxxxxxxxxx
> > >>>>
> > >>>>
> > >>
> > >>
> > >> ---------------------------------------------------------------------
> > >> To unsubscribe, e-mail: dev-unsubscribe@xxxxxxxxxxxxxxxxxx
> > >> For additional commands, e-mail: dev-help@xxxxxxxxxxxxxxxxxx
> > >>
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@xxxxxxxxxxxxxxxxxx
> > For additional commands, e-mail: dev-help@xxxxxxxxxxxxxxxxxx
> >
> >
>