git.net

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [All] CP definitions


Hi Rob.

On Wed, 19 Sep 2018 09:08:51 -0400, Rob Tompkins wrote:
My impression was that we had this conversation, and we decided that
we wanted this the other way around and to fix the components
respectively due to the semantics of the issue at hand based on what
Gary said below.

It is not clear (see my reply to Gary's message).

+1 to fix of course.
As proposed previously, [RNG] could serve as the testing ground
and future "reference" POM of a new modular component that works
with the more recent CP (with your release-plugin).[1]

Regards,
Gilles

[1] It is *not* the case currently on master ("mvn site" fails)!

-Rob

On Sep 19, 2018, at 8:45 AM, Gary Gregory <garydgregory@xxxxxxxxx> wrote:

The difference is to account for artifact ids that contain a version like commons-lang3. The component id is then just commons-lang. You must not have versions in names for certain names like in the download page. This
change will probably break builds like pool, dbcp, lang, and so on.

Gary

On Wed, Sep 19, 2018, 04:07 Gilles <gilles@xxxxxxxxxxxxxxxxxxxxx> wrote:

Hi.

Are we sure that the fix/revert below to work as intended for
*all* components?

Common usage should be enforced (e.g. to allow anyone to help
releasing any component), and ancient inconsistencies fixed.

With a concrete example of a component that has had major
version changes (and top-level package change accordingly),
what is
 commons.componentid
and what is
 project.artefactId
?

Thanks,
Gilles

On Wed, 19 Sep 2018 08:06:17 -0000, britter@xxxxxxxxxx wrote:
Author: britter
Date: Wed Sep 19 08:06:17 2018
New Revision: 1841296

URL: http://svn.apache.org/viewvc?rev=1841296&view=rev
Log:
COMMONSSITE-124: Revert change in commons.scmPubUrl in Parent 47

Modified:
   commons/proper/commons-parent/trunk/pom.xml
   commons/proper/commons-parent/trunk/src/changes/changes.xml

Modified: commons/proper/commons-parent/trunk/pom.xml
URL:



http://svn.apache.org/viewvc/commons/proper/commons-parent/trunk/pom.xml?rev=1841296&r1=1841295&r2=1841296&view=diff



==============================================================================
--- commons/proper/commons-parent/trunk/pom.xml (original)
+++ commons/proper/commons-parent/trunk/pom.xml Wed Sep 19 08:06:17
2018
@@ -1940,7 +1940,7 @@
    <!-- value modules can override it -->
    <commons.site.path>${commons.componentid}</commons.site.path>

-

<commons.scmPubUrl>

https://svn.apache.org/repos/infra/websites/production/commons/content/proper/${commons.componentid}
</commons.scmPubUrl>
+

<commons.scmPubUrl>

https://svn.apache.org/repos/infra/websites/production/commons/content/proper/${project.artifactId}
</commons.scmPubUrl>




<commons.scmPubCheckoutDirectory>${commons.site.cache}/${commons.site.path}</commons.scmPubCheckoutDirectory>
    <commons.scmPubServer>commons.site</commons.scmPubServer>


Modified: commons/proper/commons-parent/trunk/src/changes/changes.xml
URL:



http://svn.apache.org/viewvc/commons/proper/commons-parent/trunk/src/changes/changes.xml?rev=1841296&r1=1841295&r2=1841296&view=diff



==============================================================================
--- commons/proper/commons-parent/trunk/src/changes/changes.xml
(original)
+++ commons/proper/commons-parent/trunk/src/changes/changes.xml Wed
Sep 19 08:06:17 2018
@@ -61,6 +61,7 @@ The <action> type attribute can be add,u
    <body>

        <release version="48" date="YYYY-MM-DD" description="TBD">
+            <action issue="COMMONSSITE-124" type="fix"
dev="britter">Revert change in commons.scmPubUrl in Parent
47</action>
            <action type="update">Update parent from
org.apache:apache 19 to 20.</action>
            <action type="update">maven-compiler-plugin 3.7.0 ->
3.8.0</action>
            <action type="fix">re-enabled japicmp and introduced
japicmp.skip property that



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@xxxxxxxxxxxxxxxxxx
For additional commands, e-mail: dev-help@xxxxxxxxxxxxxxxxxx



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@xxxxxxxxxxxxxxxxxx
For additional commands, e-mail: dev-help@xxxxxxxxxxxxxxxxxx


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@xxxxxxxxxxxxxxxxxx
For additional commands, e-mail: dev-help@xxxxxxxxxxxxxxxxxx