git.net

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [collections] 4.2 rat issue (Was: [VOTE] Release Apache Commons Collections 4.2 based on RC1)


On Tue, Jul 10, 2018 at 2:26 PM Rob Tompkins <chtompki@xxxxxxxxx> wrote:

>
>
> > On Jul 10, 2018, at 4:20 PM, Rob Tompkins <chtompki@xxxxxxxxx> wrote:
> >
> > On Jul 10, 2018, at 4:18 PM, Gary Gregory <garydgregory@xxxxxxxxx>
> wrote:
> >>
> >> On Tue, Jul 10, 2018 at 2:08 PM Rob Tompkins <chtompki@xxxxxxxxx>
> wrote:
> >>
> >>> I’ve got two rat violations:
> >>>
> >>>
> https://dist.apache.org/repos/dist/dev/commons/collections/4.2-RC1/site/rat-report.html
> >>> <
> >>>
> https://dist.apache.org/repos/dist/dev/commons/collections/4.2-RC1/site/rat-report.html
> >>>>
> >>> but, they look like files that need to be excluded. Should this
> invalidate
> >>> the release?
> >>>
> >>
> >> Hi Rob,
> >>
> >> I noted this in the VOTE email:
> >>
> >> RAT Report:
> >>
> >>
> https://dist.apache.org/repos/dist/dev/commons/collections/4.2-RC1/site/rat-report.html
> >>   Note that RAT reports the following files with unapproved licenses:
> >>   - src/test/resources/data/test/NullComparator.version4.obj1
> >>   - src/test/resources/data/test/NullComparator.version4.obj2
> >>   These should have been excluded by the POM's exclusion list on line
> 562:
> >>     <exclude>src/test/resources/data/test/*</exclude>
> >>   but for some reason RAT marks these files are marked while the others
> >> are not.
> >>
> >> I managed to get a build once that did not have these two files listed
> as
> >> RAT violation but I can't recall what the differentiating factor was.
> >>
> >> I do not view this as a blocker, these are two of many test fixtures
> that
> >> should have been excluded.
> >
> > Pardon my mistake there. Was going through a mechanical validation,
> should have read first.
>
> Didn’t want to clutter the vote thread, but I wanted to make note that I
> didn’t have those rat errors when building with java7.
>

Good to know, thank you.

Gary


>
> Strange.
>
> -Rob
>
>
> >
> > -Rob
> >
> >>
> >> Thank you,
> >> Gary
> >>
> >>
> >>>
> >>> -Rob
> >>>
> >>>> On Jul 8, 2018, at 10:04 AM, Gary Gregory <ggregory@xxxxxxxxxx>
> wrote:
> >>>>
> >>>> We have fixed quite a few bugs and added some significant enhancements
> >>>> since Apache Commons Collections 4.1 was released, so I would like to
> >>>> release Apache Commons Collections 4.2.
> >>>>
> >>>> Apache Commons Collections 4.2 RC1 is available for review here:
> >>>>  https://dist.apache.org/repos/dist/dev/commons/collections/4.2-RC1
> >>> (svn
> >>>> revision 27987)
> >>>>
> >>>> The Git tag commons-collections-4.2-RC1 commit for this RC is
> >>>> 483cbbbf5a8b3c14edf3e6563e8f8ba380966d47 which you can browse here:
> >>>>
> >>>>
> >>>
> https://git-wip-us.apache.org/repos/asf?p=commons-collections.git;a=tag;h=refs/tags/commons-collections-4.2-RC1
> >>>>
> >>>> Maven artifacts are here:
> >>>>
> >>>>
> >>>
> https://repository.apache.org/content/repositories/orgapachecommons-1344/org/apache/commons/commons-collections4/4.2/
> >>>>
> >>>> These are the Maven artifacts and their hashes in Nexus:
> >>>>
> >>>> #Release SHA-1s
> >>>> #Sun Jul 08 07:28:05 MDT 2018
> >>>>
> >>>
> commons-collections4-4.2-sources-java-source=e8dd003d43b1f7dba173fb7e63f5c0b823f5e5c6
> >>>>
> >>>
> commons-collections4-4.2-src-zip.asc=46c4d4c6fad99750abd5d28d14043dd76808ede2
> >>>>
> commons-collections4-4.2-src-zip=62d55eb312e5a25106420919d575b07a4e72136d
> >>>>
> commons-collections4-4.2-pom.asc=848fc1d0639b8fc98b991591363575e1f7752acb
> >>>>
> >>>
> commons-collections4-4.2-src-tar.gz=8d26d4583c7d9f161dd133c5d24d269c40433532
> >>>>
> >>>
> commons-collections4-4.2-test-sources-java-source=50b773aa645cc260761db2cc7b2187013f8e667e
> >>>>
> >>>
> commons-collections4-4.2-tests-test-jar=f6a42da0fcc2daa4308b1c9bc1931339df3eca73
> >>>>
> >>>
> commons-collections4-4.2-tests-jar.asc=080d6f5696fe1a0640fb2508b23003c82763799a
> >>>>
> >>>
> commons-collections4-4.2-javadoc-javadoc=4ffc8a67913573ed78803875bf664b739564821d
> >>>>
> commons-collections4-4.2-bin-zip=ba2d36ec63545683f9792be799fe0ff6b323d8d9
> >>>>
> >>>
> commons-collections4-4.2-bin-tar.gz=910a0d873d02796bf5999f244af73313465133eb
> >>>>
> >>>
> commons-collections4-4.2-bin-tar.gz.asc=6517386ee43cf4eae752e22d2fe51b3c2de7d93a
> >>>>
> >>>
> commons-collections4-4.2-test-sources-jar.asc=6a0a640a197434b0cc5cbc78a7a523ad57550430
> >>>>
> >>>
> commons-collections4-4.2-bin-zip.asc=ee7e4096224e53ced1934536c8d3efa5df1f0518
> >>>>
> >>>
> commons-collections4-4.2-sources-jar.asc=9e9bf9aa948876a7920353bc865a81896f5dc847
> >>>>
> >>>
> commons-collections4-4.2-src-tar.gz.asc=c4ae85b480a35c1e1eb221ec5b4d116a80d80d65
> >>>>
> commons-collections4-4.2-jar.asc=1bd7e8ff20fffd02a82931f194d8942f09936144
> >>>>
> >>>
> commons-collections4-4.2-javadoc-jar.asc=6505adb8ce085b57898c354a64b2542231633b5a
> >>>>
> >>>> #Release SHA-256s
> >>>> #Sun Jul 08 07:28:05 MDT 2018
> >>>>
> >>>
> commons-collections4-4.2-sources-java-source=c8d954f1dabd8c5aedbea8cee8b64e99c1167243285bcff0caf96bf8df5a8c97
> >>>>
> >>>
> commons-collections4-4.2-src-zip.asc=1eec311645263ecbc640cc645f549e9863d4e5613911a7a0af7528642de18d30
> >>>>
> >>>
> commons-collections4-4.2-src-zip=ead0ffd114f2de0593706c5d34b883e130ec53880e8be401523d7cac99875ff5
> >>>>
> >>>
> commons-collections4-4.2-pom.asc=afa4c9052238e07b7651e06390918013cec6022aedff1915f34cccfcc4753741
> >>>>
> >>>
> commons-collections4-4.2-src-tar.gz=8b35949fe044d68d141f7ff9ea2541b5001e6d940872722877211d211f90a477
> >>>>
> >>>
> commons-collections4-4.2-test-sources-java-source=08e556c4c0f28a439d72a8772a449c43c497d7a9c1f500abe91137049e71e01e
> >>>>
> >>>
> commons-collections4-4.2-tests-test-jar=d486614c3e2174b1d9b3aaee51ade2ba2e3ec64f29dc733648377d493e74aa65
> >>>>
> >>>
> commons-collections4-4.2-tests-jar.asc=847ee3d4bd5fdccf6ec8b042afe6abdfc0727299ce43a65910b65ccbdb961665
> >>>>
> >>>
> commons-collections4-4.2-javadoc-javadoc=d1a1516b43039538c992037f6522825a053799aa0ded04dd27dede5166e4a833
> >>>>
> >>>
> commons-collections4-4.2-bin-zip=23b904d2ccb75083fbc9a3218e1ad956f5605c2ff4bcb7930c7c897a05adb5a8
> >>>>
> >>>
> commons-collections4-4.2-bin-tar.gz=91cda7f59fc31462a2ba5b2a52d3c212e2ca41f1ccaaa5603fccaffeb66e9118
> >>>>
> >>>
> commons-collections4-4.2-bin-tar.gz.asc=839eb945a960493e4dd6182c7d0274c99dfab4fdfc7ec0108f7da9cbbe060d9d
> >>>>
> >>>
> commons-collections4-4.2-test-sources-jar.asc=488a6e8070b9bce2acd21516912ca537a41e9b000ca292097520c5f08b42d8f5
> >>>>
> >>>
> commons-collections4-4.2-bin-zip.asc=9b7a4007b726b82f3cae5625d030a2ee70f433a1f0d449b8c27b5255a7061d79
> >>>>
> >>>
> commons-collections4-4.2-sources-jar.asc=27a0b5d305cc5f95ed636c5df790ae62991cdae7aac248f410d47ad6278f20b1
> >>>>
> >>>
> commons-collections4-4.2-src-tar.gz.asc=481acbe8f83ebd766d1069e539e5ec291fe6b212ec87b6313f3741b72a9381c1
> >>>>
> >>>
> commons-collections4-4.2-jar.asc=2785044fbbe95e98fb8fb8b8c2cbb9a57aa730e233877bdf502aa2ce1452ee94
> >>>>
> >>>
> commons-collections4-4.2-javadoc-jar.asc=0cfb4f2cb240c5306794423ce71e8bdc762af2e775898b00d911efd70c27184f
> >>>>
> >>>> (no need for .asc hashes!)
> >>>>
> >>>> I have tested this with 'mvn -V clean install site -P japicmp' using:
> >>>>
> >>>> Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe;
> >>>> 2018-06-17T12:33:14-06:00)
> >>>> Maven home: C:\Java\apache-maven-3.5.4\bin\..
> >>>> Java version: 1.8.0_172, vendor: Oracle Corporation, runtime:
> C:\Program
> >>>> Files\Java\jdk1.8.0_172\jre
> >>>> Default locale: en_US, platform encoding: Cp1252
> >>>> OS name: "windows 10", version: "10.0", arch: "amd64", family:
> "windows"
> >>>>
> >>>> Details of changes since 4.1 are in the release notes:
> >>>>
> >>>>
> >>>
> https://dist.apache.org/repos/dist/dev/commons/collections/4.2-RC1/RELEASE-NOTES.txt
> >>>>
> >>>>
> >>>
> https://dist.apache.org/repos/dist/dev/commons/collections/4.2-RC1/site/changes-report.html
> >>>>
> >>>> Site:
> >>>>
> >>>
> https://dist.apache.org/repos/dist/dev/commons/collections/4.2-RC1/site
> >>>>  (note some *relative* links are broken and the 4.2 directories are
> not
> >>>> yet created - these will be OK once the site is deployed.)
> >>>>
> >>>> CLIRR Report (compared to 4.1):
> >>>>
> >>>>
> >>>
> https://dist.apache.org/repos/dist/dev/commons/collections/4.2-RC1/site/clirr-report.html
> >>>>
> >>>> JApiCmp Report (compared to 4.1):
> >>>>
> >>>>
> >>>
> https://dist.apache.org/repos/dist/dev/commons/collections/4.2-RC1/site/japicmp.html
> >>>>  This report is empty for some reason, but the Clirr report is OK
> >>>>
> >>>> RAT Report:
> >>>>
> >>>>
> >>>
> https://dist.apache.org/repos/dist/dev/commons/collections/4.2-RC1/site/rat-report.html
> >>>>  Note that RAT reports the following files with unapproved licenses:
> >>>>  - src/test/resources/data/test/NullComparator.version4.obj1
> >>>>  - src/test/resources/data/test/NullComparator.version4.obj2
> >>>>  These should have been excluded by the POM's exclusion list on line
> >>> 562:
> >>>>    <exclude>src/test/resources/data/test/*</exclude>
> >>>>  but for some reason RAT marks these files are marked while the others
> >>>> are not.
> >>>>
> >>>> KEYS:
> >>>> https://www.apache.org/dist/commons/KEYS
> >>>>
> >>>> Please review the release candidate and vote.
> >>>> This vote will close no sooner that 72 hours from now.
> >>>>
> >>>> [ ] +1 Release these artifacts
> >>>> [ ] +0 OK, but...
> >>>> [ ] -0 OK, but really should fix...
> >>>> [ ] -1 I oppose this release because...
> >>>>
> >>>> Thank you,
> >>>>
> >>>> Gary Gregory,
> >>>> Release Manager (using key 86FDC7E2A11262CB)
> >>>
> >>>
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@xxxxxxxxxxxxxxxxxx
> For additional commands, e-mail: dev-help@xxxxxxxxxxxxxxxxxx
>
>