git.net

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [release-plugin] TODOs



> On May 30, 2018, at 2:40 PM, Gary Gregory <garydgregory@xxxxxxxxx> wrote:
> 
> Hi Rob:
> 
> The
> method org.apache.commons.release.plugin.mojos.CommonsDistributionDetachmentMojo.hashArtifacts()
> seems like it is only used for logging. Surely we can log hashes the first
> time we compute them. It looks like we are computing them x2.

It also generates the .md5, .sha1, and .sha256 files that travel along with the .tar.gz and .zip files using PrintWriters. That said, we should be able to pull minimally the sha1’s and sha256’s out of the maps that we generated at the beginning of the execute() method for the sake of tracking all of the generated artifacts as opposed to just those that have been detached from the deployment.

-Rob

> 
> Gary
> 
> On Wed, May 30, 2018 at 10:49 AM, Gary Gregory <garydgregory@xxxxxxxxx>
> wrote:
> 
>> 
>> 
>> On Tue, May 29, 2018 at 2:11 PM, Gary Gregory <garydgregory@xxxxxxxxx>
>> wrote:
>> 
>>> Hi Rob and All:
>>> 
>>> I see the following TODOs before releasing 1.3:
>>> 
>>> - Commit the site as is to the dist folder so that links in a VOTE email
>>> work (like 'The CLIRR report is here). I am not sure we still need the site
>>> zip. I am not sure we need to make that an option, needs feedback.
>>> - Match the dist path and tag names to match what the vote-txt goal
>>> generates (see src/main/resources/commons-xdo
>>> c-templates/vote-txt-template.txt)
>>> 
>> 
>> This matching is not an issue, the 46-SNAPSHOT parent now says:
>>    <commons.distSvnStagingUrl>scm:svn:https://dist.apache.
>> org/repos/dist/dev/commons/${commons.componentid}/${
>> commons.release.version}-${commons.rc.version}</commons.distSvnStagingUrl>
>> 
>> 
>> So until 46 comes out, a component POM needs to say the same thing to use
>> the vote-txt goal (when it comes out in the release plugin 1.3.)
>> 
>> Gary
>> 
>> 
>>> Extra Credit: How do we get the NNNN after a deploy for a URL
>>> https://repository.apache.org/content/repositories/orgap
>>> achecommons-NNNN/org/apache/commons/@ARTIFACTID@/@VERSION@/
>>> 
>>> Gary
>>> 
>> 
>> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@xxxxxxxxxxxxxxxxxx
For additional commands, e-mail: dev-help@xxxxxxxxxxxxxxxxxx