git.net

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: API Break in pods API


Thanks Nicolas for the pointer.

Breaking the API is bad, even worse that the API docs still suggest to
update start/end ips by the API updatePod AND no errors returned (silent
fail).

We left users behind here.


On 08/17/2018 01:31 AM, Nicolas Vazquez wrote:
> Hi Rene,
> 
> 
> As you mentioned it was part of the work introduced by PR 2048. I've been taking a look at its FS on this link: <https://cwiki.apache.org/confluence/display/CLOUDSTACK/Expansion+of+Management+IP+Range#ExpansionofManagementIPRange-createManagementNetworkIpRange> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Expansion+of+Management+IP+Range
> 
> 
> <https://cwiki.apache.org/confluence/display/CLOUDSTACK/Expansion+of+Management+IP+Range#ExpansionofManagementIPRange-createManagementNetworkIpRange><https://cwiki.apache.org/confluence/display/CLOUDSTACK/Expansion+of+Management+IP+Range>Under 'Architecture and Design Description' I found out these points:
> 
>   *   Now, we can only update the name, gateway and netmask of a Pod using updatePod API.
>   *   We cannot update StartIp and EndIp of the pod. Because we cannot replace them with just one range.
>   *   Even if we pass startIp and endIp parameters in updatePod API. It is considered as NULL thereafter.

This should not be handled it as NULL because as a user, you can't see
that the updating of the start/end IP did not work. Instead an error
must be returned saying how to update the IPs

Regards
René