git.net

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: PR 2670: Removing an old, unused NetApp plug-in


I actually have no idea, Rafael. Nor does there seem to be anyone remaining at NetApp who knows about that plug-in.

> On May 23, 2018, at 1:22 PM, Rafael Weingärtner <rafaelweingartner@xxxxxxxxx> wrote:
> 
> Those APi methods that you are removing as well (AssociateLunCmd.java,
> CreateLunCmd.java, CreateVolumeOnFilerCmd.java,  CreateVolumePoolCmd.java,
> DeleteVolumePoolCmd.java, DestroyLunCmd.java, DestroyVolumeOnFilerCmd.java,
> DissociateLunCmd.java, ListLunsCmd.java, ListVolumePoolsCmd.java, and so
> on), are they ony used for this NetApp plugin? It seems a considerable
> number of external API methods being removed.
> 
> I also have another question. Are all of these methods broken? I mean, do
> they work?
> 
>> On Wed, May 23, 2018 at 4:13 PM, Will Stevens <wstevens@xxxxxxxxxxxx> wrote:
>> 
>> +1
>> 
>> On Wed, May 23, 2018, 3:03 PM Gabriel Beims Bräscher, <
>> gabriel@xxxxxxxxxxxx>
>> wrote:
>> 
>>> I am +1 on removing it.
>>> 
>>>> On May 23, 2018 at 8:59 PM Paul Angus <paul.angus@xxxxxxxxxxxxx>
>> wrote:
>>>> 
>>>> 
>>>> +1
>>>> 
>>>> There's a NetApp Jar in the nodist which is related I think - be nice
>> to
>>> get rid of that too.
>>>> 
>>>> paul.angus@xxxxxxxxxxxxx
>>>> www.shapeblue.com
>>>> 53 Chandos Place, Covent Garden, London WC2N 4HSUK
>>>> @shapeblue
>>>> 
>>>> 
>>>> 
>>>> 
>>>> -----Original Message-----
>>>> From: Tutkowski, Mike <Mike.Tutkowski@xxxxxxxxxx>
>>>> Sent: 23 May 2018 19:53
>>>> To: dev@xxxxxxxxxxxxxxxxxxxxx
>>>> Subject: PR 2670: Removing an old, unused NetApp plug-in
>>>> 
>>>> Hi everyone,
>>>> 
>>>> I opened the following PR today:
>>>> 
>>>> https://github.com/apache/cloudstack/pull/2670
>>>> 
>>>> There is an old, what we believe to be unused, NetApp plug-in in the
>>> CloudStack codebase that I’d like to remove.
>>>> 
>>>> I’m sending this e-mail out for the following reasons:
>>>> 
>>>> 
>>>> 1) To see if, by chance, anyone is actually using this plug-in.
>>>> 
>>>> 2) To direct any potential code reviewers to this PR, where I have
>>> placed a couple questions about my commit.
>>>> 
>>>> To be absolutely clear here, this has nothing to do with any of the
>>> SolidFire plug-ins (only an old NetApp plug-in that hasn’t been updated
>> in
>>> years and is probably not being used by anyone).
>>>> 
>>>> Thanks,
>>>> Mike
>>> 
>> 
> 
> 
> 
> -- 
> Rafael Weingärtner