git.net

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: GitHub PR ticket spam


+1

> Or perhaps we should require committers to summarise in the comments.  For
> most tickets, perhaps just stating ’nits from GitHub comments’.  But for
> any complex tickets, summarising the conclusions of any unexpected logical
> or structural discussion would be really helpful for posterity.  This has
> always been true, but especially so now, given how hard the replicated
> comments are to parse.

Yeah this. I think design discussion should continue to at least be
summarised in the comments. The worklog is still going to be painful to
parse, so should really only be used for the minor details and a record
IMO. I don't think we need to make this a hard requirement though, people
already do this so as long as we keep doing it setting the example should
be good enough.


On 7 August 2018 at 02:52, Benedict Elliott Smith <benedict@xxxxxxxxxx>
wrote:

> Also +1
>
> It might perhaps be nice to (just once) have ASF Bot comment that a GitHub
> discussion has been replicated to the worklog? In the Arrow example, for
> instance, it isn’t immediately obvious that there are any worklog comments
> to look at.
>
> Or perhaps we should require committers to summarise in the comments.  For
> most tickets, perhaps just stating ’nits from GitHub comments’.  But for
> any complex tickets, summarising the conclusions of any unexpected logical
> or structural discussion would be really helpful for posterity.  This has
> always been true, but especially so now, given how hard the replicated
> comments are to parse.
>
>
> > On 6 Aug 2018, at 17:18, Jeremiah D Jordan <jeremiah.jordan@xxxxxxxxx>
> wrote:
> >
> > Oh nice.  I like the idea of keeping it but moving it to the worklog
> tab.  +1 on that from me.
> >
> >> On Aug 6, 2018, at 5:34 AM, Stefan Podkowinski <spod@xxxxxxxxxx> wrote:
> >>
> >> +1 for worklog option
> >>
> >> Here's an example ticket from Arrow, where they seem to be using the
> >> same approach:
> >> https://urldefense.proofpoint.com/v2/url?u=https-3A__issues.
> apache.org_jira_browse_ARROW-2D2583&d=DwICaQ&c=adz96Xi0w1RHqtPMowiL2g&r=
> CNZK3RiJDLqhsZDG6FQGnXn8WyPRCQhp4x_uBICNC0g&m=wYZwHSze6YITTXgzOrEvfr_
> onojahtjeJRzGAt8ByzM&s=KWt0xsOv9ESaieg432edGvPhktGkWHxVuLAdNyORiYY&e= <
> https://urldefense.proofpoint.com/v2/url?u=https-
> 3A__issues.apache.org_jira_browse_ARROW-2D2583&d=DwICaQ&
> c=adz96Xi0w1RHqtPMowiL2g&r=CNZK3RiJDLqhsZDG6FQGnXn8WyPRCQhp4x_uBICNC0g&m=
> wYZwHSze6YITTXgzOrEvfr_onojahtjeJRzGAt8ByzM&s=
> KWt0xsOv9ESaieg432edGvPhktGkWHxVuLAdNyORiYY&e=>
> >>
> >>
> >> On 05.08.2018 09:56, Mick Semb Wever wrote:
> >>>> I find this a bit annoying while subscribed to commits@,
> >>>> especially since we created pr@ for these kind of messages. Also I
> don't
> >>>> really see any value in mirroring all github comments to the ticket.
> >>>
> >>>
> >>> I agree with you Stefan. It makes the jira tickets quite painful to
> read. And I tend to make comments on the commits rather than the PRs so to
> avoid spamming back to the jira ticket.
> >>>
> >>> But the linking to the PR is invaluable. And I can see Ariel's point
> about a chronological historical archive.
> >>>
> >>>
> >>>> Ponies would be for this to be mirrored to a tab
> >>>> separate from comments in JIRA.
> >>>
> >>>
> >>> Ariel, that would be the the "worklog" option.
> >>> https://urldefense.proofpoint.com/v2/url?u=https-3A__
> reference.apache.org_pmc_github&d=DwICaQ&c=adz96Xi0w1RHqtPMowiL2g&r=
> CNZK3RiJDLqhsZDG6FQGnXn8WyPRCQhp4x_uBICNC0g&m=wYZwHSze6YITTXgzOrEvfr_
> onojahtjeJRzGAt8ByzM&s=1lWQawAO9fITzakpnmdzERuCbZs6IGQsUH_EEIMCMqs&e= <
> https://urldefense.proofpoint.com/v2/url?u=https-
> 3A__reference.apache.org_pmc_github&d=DwICaQ&c=adz96Xi0w1RHqtPMowiL2g&r=
> CNZK3RiJDLqhsZDG6FQGnXn8WyPRCQhp4x_uBICNC0g&m=wYZwHSze6YITTXgzOrEvfr_
> onojahtjeJRzGAt8ByzM&s=1lWQawAO9fITzakpnmdzERuCbZs6IGQsUH_EEIMCMqs&e=>
> >>>
> >>> If this works for you, and others, I can open a INFRA to switch to
> worklog.
> >>> wdyt?
> >>>
> >>>
> >>> Mick.
> >>>
> >>> ---------------------------------------------------------------------
> >>> To unsubscribe, e-mail: dev-unsubscribe@xxxxxxxxxxxxxxxxxxxx <mailto:
> dev-unsubscribe@xxxxxxxxxxxxxxxxxxxx>
> >>> For additional commands, e-mail: dev-help@xxxxxxxxxxxxxxxxxxxx
> <mailto:dev-help@xxxxxxxxxxxxxxxxxxxx>
> >>>
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscribe@xxxxxxxxxxxxxxxxxxxx <mailto:
> dev-unsubscribe@xxxxxxxxxxxxxxxxxxxx>
> >> For additional commands, e-mail: dev-help@xxxxxxxxxxxxxxxxxxxx <mailto:
> dev-help@xxxxxxxxxxxxxxxxxxxx>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@xxxxxxxxxxxxxxxxxxxx
> For additional commands, e-mail: dev-help@xxxxxxxxxxxxxxxxxxxx
>
>


( ! ) Warning: include(msgfooter.php): failed to open stream: No such file or directory in /var/www/git/apache-cassandra-development/msg02461.html on line 181
Call Stack
#TimeMemoryFunctionLocation
10.0007368752{main}( ).../msg02461.html:0

( ! ) Warning: include(): Failed opening 'msgfooter.php' for inclusion (include_path='.:/var/www/git') in /var/www/git/apache-cassandra-development/msg02461.html on line 181
Call Stack
#TimeMemoryFunctionLocation
10.0007368752{main}( ).../msg02461.html:0