git.net

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: GitHub PR ticket spam


Hi,

I really like having it mirrored. I would not be in favor of eliminating automated mirroring. What we are seeing is that removing the pain of commenting in JIRA is encouraging people to converse more in finer detail. That's a good thing.

I have also seen the pain of how various github workflows hide PRs. Rebasing, squashing, multiple branches, all of these can obfuscate the history of a review. So mirroring stuff to JIRA still makes sense to me as it's easier to untangle what happened in chronological order.

I think reducing verbosity to not include diffs is good. Especially if it contains a link to the comment. I do like being able to see the diff in JIRA (context switching bad) I just don't like to see it mixed in with regular comments. Ponies would be for this to be mirrored to a tab separate from comments in JIRA.

Regards,
Ariel

On Mon, Jul 30, 2018, at 1:25 PM, dinesh.joshi@xxxxxxxxx.INVALID wrote:
> It is useful to have a historical record. However, it could definitely 
> be better (huge diffs are pointless).
> Thanks,
> Dinesh 
> 
>     On Monday, July 30, 2018, 1:27:26 AM PDT, Stefan Podkowinski 
> <spod@xxxxxxxxxx> wrote:  
>  
>  Looks like we had some active PRs recently to discuss code changes in
> detail on GitHub, which I think is something we agreed is perfectly
> fine, in addition to the usual Jira ticket.
> 
> What bugs me a bit is that for some reasons any comments on the PR would
> be posted to the Jira ticket as well. I'm not sure what would be the
> exact reason for this, I guess it's because the PR is linked in the
> ticket? I find this a bit annoying while subscribed to commits@,
> especially since we created pr@ for these kind of messages. Also I don't
> really see any value in mirroring all github comments to the ticket.
> #14556 is a good example how you could end up with tons of unformatted
> code in the ticket that will also mess up search in jira. Does anyone
> think this is really useful, or can we stop linking the PR in the future
> (at least for highly active PRs)?
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@xxxxxxxxxxxxxxxxxxxx
> For additional commands, e-mail: dev-help@xxxxxxxxxxxxxxxxxxxx
> 
>   

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@xxxxxxxxxxxxxxxxxxxx
For additional commands, e-mail: dev-help@xxxxxxxxxxxxxxxxxxxx




( ! ) Warning: include(msgfooter.php): failed to open stream: No such file or directory in /var/www/git/apache-cassandra-development/msg02442.html on line 115
Call Stack
#TimeMemoryFunctionLocation
10.0009364520{main}( ).../msg02442.html:0

( ! ) Warning: include(): Failed opening 'msgfooter.php' for inclusion (include_path='.:/var/www/git') in /var/www/git/apache-cassandra-development/msg02442.html on line 115
Call Stack
#TimeMemoryFunctionLocation
10.0009364520{main}( ).../msg02442.html:0