git.net

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[GitHub] nicolaferraro commented on a change in pull request #238: initial support for custom maven repositories


nicolaferraro commented on a change in pull request #238: initial support for custom maven repositories
URL: https://github.com/apache/camel-k/pull/238#discussion_r236034441
 
 

 ##########
 File path: pkg/apis/camel/v1alpha1/types.go
 ##########
 @@ -56,6 +56,7 @@ type IntegrationSpec struct {
 	Profile       TraitProfile                    `json:"profile,omitempty"`
 	Traits        map[string]IntegrationTraitSpec `json:"traits,omitempty"`
 	Configuration []ConfigurationSpec             `json:"configuration,omitempty"`
+	Repositories  []string                        `json:"repositories,omitempty"`
 
 Review comment:
   I think it's important to set this at `Integration` level as you did, but it's more to support snippets in the future... I'd put it also at `IntegrationPlatform` level, so that one can specify repositories for the global installation.
   
   And the one at integration level overrides the one at platform level. I'm not sure about context level repo.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@xxxxxxxxxxxxxxxx


With regards,
Apache Git Services