git.net

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Re-generating source code - Modified source files afterwards


Hi

Okay I found the issue; actually it was myself ;)
And have pushed it upstream

On Wed, Aug 8, 2018 at 10:12 AM, Claus Ibsen <claus.ibsen@xxxxxxxxx> wrote:
> On Wed, Aug 8, 2018 at 10:08 AM, Zoran Regvart <zoran@xxxxxxxxxxx> wrote:
>> Hi Claus,
>> happens exactly like that on my end, are we using unordered
>> collections for the schemes of the component?
>>
>
> I think the maven tooling may haven been changed recently and I only
> noticed this when I got back from PTO where there were a lot of code
> changes on master branch.
>
> Yeah it smells like unordered list, or a file system that list the
> files in a different order now.
>
> The thing is that a component can have an alternative syntax (https
> instead of http) but the component generally act similar.
> So it smells like either an unordered list issue or that some code was
> changed to not take into account for this alternative syntax issue.
>
> I will log a ticket and investigate this. At first I just wanted to
> know if it was only me or only a mac issue etc.
> https://issues.apache.org/jira/browse/CAMEL-12716
>
>
>> zoran
>>
>> On Wed, Aug 8, 2018 at 8:31 AM, Claus Ibsen <claus.ibsen@xxxxxxxxx> wrote:
>>> Hi
>>>
>>> When I do a full re-gen of the source code via
>>>
>>> mvn clean install -P fastinstall
>>>
>>> Then afterwards I now have 5 modified files
>>>
>>> modified:   platforms/spring-boot/components-starter/camel-ahc-ws-starter/src/main/java/org/apache/camel/component/ahc/ws/springboot/WsComponentConfiguration.java
>>> modified:   platforms/spring-boot/components-starter/camel-http-starter/src/main/java/org/apache/camel/component/http/springboot/HttpComponentConfiguration.java
>>> modified:   platforms/spring-boot/components-starter/camel-http4-starter/src/main/java/org/apache/camel/component/http4/springboot/HttpComponentConfiguration.java
>>> modified:   platforms/spring-boot/components-starter/camel-mail-starter/src/main/java/org/apache/camel/component/mail/springboot/MailComponentConfiguration.java
>>> modified:   platforms/spring-boot/components-starter/camel-sip-starter/src/main/java/org/apache/camel/component/sip/springboot/SipComponentConfiguration.java
>>>
>>>
>>> I think some of our Camel maven tooling etc that generates these
>>> files, likely was changed recently and is causing this.
>>>
>>> I wonder if others have these same 5 files modified as well. And if I
>>> do a diff then their modification is "wrong". As its component with
>>> multiple schemes, eg http and https. Where we would use the first
>>> scheme, eg http in the generated file. But now for me it uses the
>>> latter
>>>
>>> -     * Whether to enable auto configuration of the http component. This is
>>> +     * Whether to enable auto configuration of the https component. This is
>>>
>>>
>>> I wonder if this is platform dependent, eg mac vs linux vs windows etc?
>>>
>>>
>>>
>>>
>>>
>>>
>>>
>>> --
>>> Claus Ibsen
>>> -----------------
>>> http://davsclaus.com @davsclaus
>>> Camel in Action 2: https://www.manning.com/ibsen2
>>
>>
>>
>> --
>> Zoran Regvart
>
>
>
> --
> Claus Ibsen
> -----------------
> http://davsclaus.com @davsclaus
> Camel in Action 2: https://www.manning.com/ibsen2



-- 
Claus Ibsen
-----------------
http://davsclaus.com @davsclaus
Camel in Action 2: https://www.manning.com/ibsen2