git.net

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [VOTE] Release apache-calcite-1.18.0 (release candidate 1)


+1 (non binding)

System: Ubuntu 18.04 LTS and jdk1.8.0.66

-run mvn clean install on staged sources and git repo
-checked signatures and checksums
-went quickly over release note

Everything looks good! I have only a small question: should the release
note mention new dependencies (e.g., com.jayway.jsonpath)?

-run tests on downstream project

Still many failures mostly due to the following bugs:

* [CALCITE-2464] Struct types are always not nullable [1]
* [CALCITE-2677] Struct types with one field are not mapped correctly to
Java Classes [2]

These are not regressions so my +1 vote remains.

Best,
Stamatis

[1] https://issues.apache.org/jira/browse/CALCITE-2464
[2] https://issues.apache.org/jira/browse/CALCITE-2677


Στις Πέμ, 6 Δεκ 2018 στις 9:19 π.μ., ο/η Julian Hyde <jhyde@xxxxxxxxxx>
έγραψε:

> OK, let's try again.
>
> I have created a build for Apache Calcite 1.18.0, release candidate 1.
>
> Thanks to everyone who has contributed to this release.
> Since RC 0, we have fixed the following issues:
>
> * [CALCITE-2726] ReduceExpressionRule oversimplifies filter conditions
> containing nulls
> * [CALCITE-2670] Combine similar JSON aggregate functions in operator table
> * [CALCITE-2468] Validator throws IndexOutOfBoundsException when
> trying to infer operand type from STRUCT return type (Rong Rong)
>
> You can read the release notes here:
> https://github.com/apache/calcite/blob/branch-1.18/site/_docs/history.md
>
> The commit to be voted upon:
>
> http://git-wip-us.apache.org/repos/asf/calcite/commit/06d0526e9e58b88bb6722ae3e66789b9e60a70d1
>
> Its hash is 06d0526e9e58b88bb6722ae3e66789b9e60a70d1.
>
> The artifacts to be voted on are located here:
> https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.18.0-rc1
>
> The hashes of the artifacts are as follows:
> src.tar.gz.sha256
> 88501d9c22c5cd28c2988a1f921fa112386ac819fb1dbcc5f68504b30b8d7dd7
>
> A staged Maven repository is available for review at:
> https://repository.apache.org/content/repositories/orgapachecalcite-1050
>
> Release artifacts are signed with the following key:
> https://people.apache.org/keys/committer/jhyde.asc
>
> Please vote on releasing this package as Apache Calcite 1.18.0.
>
> The vote is open for the next 108 hours (ending at 1pm Pacific on Mon 10th)
> and passes if a majority of at least three +1 PMC votes are cast.
>
> [ ] +1 Release this package as Apache Calcite 1.18.0
> [ ]  0 I don't feel strongly about it, but I'm okay with the release
> [ ] -1 Do not release this package because...
>
>
> Here is my vote:
>
> +1 (binding)
>
> Julian
>