git.net

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: calcite-avatica git commit: [CALCITE-2412] Add appveyor.yml to have tests on Windows against jdk1.8, jdk9, jdk10 Add Appveyor badge Add -DskipDockerCheck because of CALCITE-2385 and to make it sync with travis.yml


Git for Windows includes a Windows port of bash (git bash), so bash scripts should work just fine.

We just need to be careful with the commands we use as we need to make sure they are ones that are also shipped with Git for Windows.

For reference: https://stackoverflow.com/a/18278072/624884

On 22/11/2018 1:01 pm, Michael Mior wrote:
I could be wrong, but my understanding was that on Windows (as on other
platforms), hooks are simply scripts that are executed. Given that we can't
run a bash script on Windows (without making unnecessary assumptions about
the environment), it seems a second script would be needed.

--
Michael Mior
mmior@xxxxxxxxxx


Le mer. 21 nov. 2018 à 09:47, Vladimir Sitnikov <sitnikov.vladimir@xxxxxxxxx>
a écrit :

Michael>Unfortunately, to work on Windows, I believe we would need to write
two
Michael>versions of the hook.

Why do you think so?

Vladimir