[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Automatic validation for commit messages

Re: Vladimir's suggestion to run the hooks only on master. I think this is a good idea. Sometimes I like to add a few test commits on my branch to test whether something works correctly (i.e. testing avatica release goal) before making a proper commit.

On 20/11/2018 6:24 pm, Julian Hyde wrote:
Before we embark on this, are we all agreed that once this hook is in place, no one will say “Hey, why are you complaining about my commit message? It passed the validation.”

People seem to think that any formatting errors not found by checkstyle are - by definition - not formatting errors, and I don’t want to repeat the same mistake here.


On Nov 19, 2018, at 11:13 PM, Vladimir Sitnikov <sitnikov.vladimir@xxxxxxxxx> wrote:

I've updated the subject to match the actual content

Francis>I feel that a git hook would probably still be the easiest and
Francis>way to get started

1) Just in case: I guess we need to confine automatic validation for
"master" branch only (or alike).

For instance, I tend to create tons of oops/fixup/t/tmp commits, and I
don't really want for the validator to blame me on each and every commit.
Ideally, it would validate only for "on push to apache.../master" (and/or
on commit to "local master branch")

2) Starting from Git 2.9, hook location could be configured via
core.hooksPath (see ), so I guess we
would be fine if we just add the hooks to .githooks folder + a command to
activate it.
It's not clear if we should try to activate the hooks automatically (e.g.
at mvn validate or something like that), however we could do that for
Travis and it could produce decent coverage.

PS. They say, Git on Windows executes hooks via its own bash, so the hooks
should just work: