git.net

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Pull requests to review


>There is no explicit time zone here provided, only the implicit one based
on

There's connection-default time zone
(see org.apache.calcite.DataContext.Variable#TIME_ZONE )

I think the way to go there is:
1) Convert SqlNod to Rex via SqlToRelConverter
2) Evaluate the Rex with something like ReduceExpressionsRule with
exception that non-constant parameters are replaced with nulls
(ReduceExpressionsRule has a machinery to determine if expression is a
constant or not)

That would make the thing consistent with existing computations/casts
(which are tricky to get right).

Vladimir