git.net

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [2/2] calcite git commit: [CALCITE-2347] running ElasticSearch in embedded mode for unit tests of ES adapter (Andrei Sereda)


Thanks!
--
Michael Mior
mmior@xxxxxxxxxx



Le lun. 25 juin 2018 à 20:17, Julian Hyde <jhyde@xxxxxxxxxx> a écrit :

> I’m reviewing and testing just the package-exclusion part now. Hopefully
> will commit shortly.
>
> > On Jun 25, 2018, at 2:11 PM, Andrei Sereda <andrei@xxxxxxxxx> wrote:
> >
> > PS. ES2+ES5 changes will be submitted in a couple of days.
> >
> > On Mon, Jun 25, 2018 at 4:56 PM Andrei Sereda <andrei@xxxxxxxxx> wrote:
> >
> >> Temporary excluded elasticsearch2 package from javadoc. This should
> >> unblock users.
> >> Tested with JDK 8,9 and 10 (maven 3.5.2 / 3.5.4) macOSX
> >>
> >> Please double-check PR-741 <https://github.com/apache/calcite/pull/741>
> >>
> >> CALCITE-2376 (unify ES2 and ES5) has been agreed upon with Christian and
> >> Michael. Once implemented, it should automatically fix current classpath
> >> issue in javadoc.
> >>
> >>
> >> On Mon, Jun 25, 2018 at 2:23 PM Andrei Sereda <andrei@xxxxxxxxx> wrote:
> >>
> >>> OK. I'm working on it.
> >>>
> >>> On Mon, Jun 25, 2018 at 2:18 PM Julian Hyde <jhyde@xxxxxxxxxx> wrote:
> >>>
> >>>>> On Jun 25, 2018, at 11:11 AM, Andrei Sereda <andrei@xxxxxxxxx>
> wrote:
> >>>>>
> >>>>> Would you consider merging this partial javadoc fix (PR 741
> >>>>> <https://github.com/apache/calcite/pull/741>) as precursor for
> >>>> CALCITE-2376 ?
> >>>>> Former PR has also fixes javadoc issues for mongo adapter.
> >>>>
> >>>> No.
> >>>>
> >>>> I have 5 commits that I would like to merge but cannot because my
> builds
> >>>> fail. We need to fix the big problem before we do anything else.
> >>>>
> >>>>> I'm working on CALCITE-2376 which unifies ES2 and ES5 adapters. I'll
> >>>> make
> >>>>> sure it is passing both javadoc / site tasks in maven.
> >>>>
> >>>> Sounds very cool, but I’m not an ES expert. I think you should get
> >>>> buy-in from other people who have worked on the ES adapter(s) before
> you go
> >>>> too far down that path.
> >>>>
> >>>> Also, it is a big solution to a small (but urgent) problem. Let’s fix
> >>>> that problem with a quick, small fix.
> >>>>
> >>>>> On a separate note, do you think it makes sense to add javadoc
> >>>> generation
> >>>>> to travis build ?
> >>>>
> >>>> I would love to, but IIRC, travis times out if you add javadoc
> >>>> generation.
> >>>>
> >>>> Julian
> >>>>
> >>>>
>
>